Re: [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR

2007-02-19 Thread Oleg Nesterov
On 02/19, David Howells wrote: > > Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is > > never used ??? > > That's a remarkably good point. Did something get deleted since I made my > modifications? At first I thought the

Re: [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR

2007-02-19 Thread David Howells
Oleg Nesterov <[EMAIL PROTECTED]> wrote: > pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is > never used ??? That's a remarkably good point. Did something get deleted since I made my modifications? Perhaps the workqueue stuff in that file should just be deleted

Re: [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR

2007-02-19 Thread David Howells
Oleg Nesterov [EMAIL PROTECTED] wrote: pp_cam_entry-cb_task need not to be _NOAUTOREL ... because in fact it is never used ??? That's a remarkably good point. Did something get deleted since I made my modifications? Perhaps the workqueue stuff in that file should just be deleted entirely.

Re: [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR

2007-02-19 Thread Oleg Nesterov
On 02/19, David Howells wrote: Oleg Nesterov [EMAIL PROTECTED] wrote: pp_cam_entry-cb_task need not to be _NOAUTOREL ... because in fact it is never used ??? That's a remarkably good point. Did something get deleted since I made my modifications? At first I thought the same. But no,

[PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR

2007-02-18 Thread Oleg Nesterov
pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is never used ??? Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> --- WQ/drivers/media/video/cpia_pp.c~3_cpia_pp 2006-12-17 19:06:40.0 +0300 +++ WQ/drivers/media/video/cpia_pp.c2007-02-19 00:27:41.0

[PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR

2007-02-18 Thread Oleg Nesterov
pp_cam_entry-cb_task need not to be _NOAUTOREL ... because in fact it is never used ??? Signed-off-by: Oleg Nesterov [EMAIL PROTECTED] --- WQ/drivers/media/video/cpia_pp.c~3_cpia_pp 2006-12-17 19:06:40.0 +0300 +++ WQ/drivers/media/video/cpia_pp.c2007-02-19 00:27:41.0 +0300