Re: [PATCH 3/3] fs: fat: add ioctl method in fat filesystem driver

2018-01-30 Thread Pali Rohár
On Tuesday 30 January 2018 20:23:03 OGAWA Hirofumi wrote: > chenchacha writes: > > > On 01/29/2018 09:02 PM, OGAWA Hirofumi wrote: > >> ChenGuanqiao writes: > >> > >>> +static int fat_check_d_characters(char *label, unsigned long len) > >>> +{ > >>> + int i; > >>> + > >>> + for (i = 0; i < len;

Re: [PATCH 3/3] fs: fat: add ioctl method in fat filesystem driver

2018-01-30 Thread OGAWA Hirofumi
chenchacha writes: > On 01/29/2018 09:02 PM, OGAWA Hirofumi wrote: >> ChenGuanqiao writes: >> >>> +static int fat_check_d_characters(char *label, unsigned long len) >>> +{ >>> + int i; >>> + >>> + for (i = 0; i < len; ++i) { >>> + switch (label[i]) { >>> + case 'a' ... 'z

Re: [PATCH 3/3] fs: fat: add ioctl method in fat filesystem driver

2018-01-30 Thread Pali Rohár
On Tuesday 30 January 2018 14:33:49 Chen Guanqiao wrote: > On Mon, 2018-01-29 at 17:43 +0100, Pali Rohár wrote: > > On Monday 29 January 2018 15:18:42 Andy Shevchenko wrote: > > > +Cc: Pali, who AFAIRC is interested in FAT labeling mess. > > > > Yes, please CC me for FAT labeling discussing in fut

Re: [PATCH 3/3] fs: fat: add ioctl method in fat filesystem driver

2018-01-29 Thread Pali Rohár
On Monday 29 January 2018 15:18:42 Andy Shevchenko wrote: > +Cc: Pali, who AFAIRC is interested in FAT labeling mess. Yes, please CC me for FAT labeling discussing in future. > On Wed, Jan 17, 2018 at 12:43 PM, ChenGuanqiao > wrote: > > Commit message? > > > Signed-off-by: ChenGuanqiao > > >

Re: [PATCH 3/3] fs: fat: add ioctl method in fat filesystem driver

2018-01-29 Thread Andy Shevchenko
+Cc: Pali, who AFAIRC is interested in FAT labeling mess. On Wed, Jan 17, 2018 at 12:43 PM, ChenGuanqiao wrote: Commit message? > Signed-off-by: ChenGuanqiao > #include > #include > #include > +#include It would be better to squeeze it to have order (to some extent) preserved. > +sta

Re: [PATCH 3/3] fs: fat: add ioctl method in fat filesystem driver

2018-01-29 Thread OGAWA Hirofumi
ChenGuanqiao writes: > +static int fat_check_d_characters(char *label, unsigned long len) > +{ > + int i; > + > + for (i = 0; i < len; ++i) { > + switch (label[i]) { > + case 'a' ... 'z': > + label[i] = __toupper(label[i]); > + case

[PATCH 3/3] fs: fat: add ioctl method in fat filesystem driver

2018-01-17 Thread ChenGuanqiao
Signed-off-by: ChenGuanqiao --- fs/fat/file.c | 132 ++ 1 file changed, 132 insertions(+) diff --git a/fs/fat/file.c b/fs/fat/file.c index 4724cc9ad650..a885f92df1eb 100644 --- a/fs/fat/file.c +++ b/fs/fat/file.c @@ -15,11 +15,33 @@ #inclu