On Tue, Feb 18, 2014 at 07:17:04PM +, Jonathan Cameron wrote:
>
>
> On February 18, 2014 3:34:14 PM GMT+00:00, Johannes Thumshirn
> wrote:
> >Add support for MEN 16z188 ADC IP Core on MCB FPGAs.
> >
> >Signed-off-by: Johannes Thumshirn
> Looks pretty good apart from the nitpicks. One more li
On February 18, 2014 3:34:14 PM GMT+00:00, Johannes Thumshirn
wrote:
>Add support for MEN 16z188 ADC IP Core on MCB FPGAs.
>
>Signed-off-by: Johannes Thumshirn
Looks pretty good apart from the nitpicks. One more little thing...
>---
> drivers/iio/adc/Kconfig| 10 +++
> drivers/iio/adc/
On top of what Peter said. Just some nitpicks...
[...]
+static struct iio_chan_spec z188_adc_iio_channels[] = {
const
+ Z188_ADC_CHANNEL(0),
+ Z188_ADC_CHANNEL(1),
+ Z188_ADC_CHANNEL(2),
+ Z188_ADC_CHANNEL(3),
+ Z188_ADC_CHANNEL(4),
+ Z188_ADC_CHANNEL(5),
+
some quick comments below...
> Add support for MEN 16z188 ADC IP Core on MCB FPGAs.
> Signed-off-by: Johannes Thumshirn
> ---
> drivers/iio/adc/Kconfig| 10 +++
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/men_z188_adc.c | 172
> +++
Add support for MEN 16z188 ADC IP Core on MCB FPGAs.
Signed-off-by: Johannes Thumshirn
---
drivers/iio/adc/Kconfig| 10 +++
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/men_z188_adc.c | 172 +
3 files changed, 183 insertions(+)
create
5 matches
Mail list logo