Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-21 Thread javier.g...@samsung.com
On 19.06.2020 09:44, Jens Axboe wrote: On 6/19/20 9:40 AM, Matias Bjørling wrote: On 19/06/2020 17.20, Jens Axboe wrote: On 6/19/20 9:14 AM, Matias Bjørling wrote: On 19/06/2020 16.18, Jens Axboe wrote: On 6/19/20 5:15 AM, Matias Bjørling wrote: On 19/06/2020 11.41, javier.g...@samsung.com w

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-21 Thread javier.g...@samsung.com
On 19.06.2020 09:02, Jens Axboe wrote: On 6/19/20 8:59 AM, Pavel Begunkov wrote: On 19/06/2020 17:15, Jens Axboe wrote: On 6/19/20 3:41 AM, javier.g...@samsung.com wrote: Jens, Would you have time to answer a question below in this thread? On 18.06.2020 11:11, javier.g...@samsung.com wrote:

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Pavel Begunkov
On 19/06/2020 17:15, Jens Axboe wrote: > On 6/19/20 3:41 AM, javier.g...@samsung.com wrote: >> Jens, >> >> Would you have time to answer a question below in this thread? >> >> On 18.06.2020 11:11, javier.g...@samsung.com wrote: >>> On 18.06.2020 08:47, Damien Le Moal wrote: On 2020/06/18 17:35

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Jens Axboe
On 6/19/20 8:59 AM, Pavel Begunkov wrote: > On 19/06/2020 17:15, Jens Axboe wrote: >> On 6/19/20 3:41 AM, javier.g...@samsung.com wrote: >>> Jens, >>> >>> Would you have time to answer a question below in this thread? >>> >>> On 18.06.2020 11:11, javier.g...@samsung.com wrote: On 18.06.2020 08

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Matias Bjørling
On 19/06/2020 16.18, Jens Axboe wrote: On 6/19/20 5:15 AM, Matias Bjørling wrote: On 19/06/2020 11.41, javier.g...@samsung.com wrote: Jens, Would you have time to answer a question below in this thread? On 18.06.2020 11:11, javier.g...@samsung.com wrote: On 18.06.2020 08:47, Damien Le Moal w

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Jens Axboe
On 6/19/20 9:14 AM, Matias Bjørling wrote: > On 19/06/2020 16.18, Jens Axboe wrote: >> On 6/19/20 5:15 AM, Matias Bjørling wrote: >>> On 19/06/2020 11.41, javier.g...@samsung.com wrote: Jens, Would you have time to answer a question below in this thread? On 18.06.2020 11:11

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Jens Axboe
On 6/19/20 9:22 AM, Alexey Dobriyan wrote: >> uint64_t val = cqe->res; // assuming non-error here >> >> if (cqe->flags & IORING_CQE_F_ZONE_FOO) >> val |= (cqe->flags >> 16) << 32ULL; > > Jens, ULL in shift doesn't do anything for widening the result. > You need > > va

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Jens Axboe
On 6/19/20 9:40 AM, Matias Bjørling wrote: > On 19/06/2020 17.20, Jens Axboe wrote: >> On 6/19/20 9:14 AM, Matias Bjørling wrote: >>> On 19/06/2020 16.18, Jens Axboe wrote: On 6/19/20 5:15 AM, Matias Bjørling wrote: > On 19/06/2020 11.41, javier.g...@samsung.com wrote: >> Jens, >>

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Matias Bjørling
On 19/06/2020 17.20, Jens Axboe wrote: On 6/19/20 9:14 AM, Matias Bjørling wrote: On 19/06/2020 16.18, Jens Axboe wrote: On 6/19/20 5:15 AM, Matias Bjørling wrote: On 19/06/2020 11.41, javier.g...@samsung.com wrote: Jens, Would you have time to answer a question below in this thread? On 18.

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Alexey Dobriyan
> uint64_t val = cqe->res; // assuming non-error here > > if (cqe->flags & IORING_CQE_F_ZONE_FOO) > val |= (cqe->flags >> 16) << 32ULL; Jens, ULL in shift doesn't do anything for widening the result. You need val |= (uint64_t)(cqe->flags >> 16) << 32;

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Jens Axboe
On 6/19/20 5:15 AM, Matias Bjørling wrote: > On 19/06/2020 11.41, javier.g...@samsung.com wrote: >> Jens, >> >> Would you have time to answer a question below in this thread? >> >> On 18.06.2020 11:11, javier.g...@samsung.com wrote: >>> On 18.06.2020 08:47, Damien Le Moal wrote: On 2020/06/18

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Jens Axboe
On 6/19/20 3:41 AM, javier.g...@samsung.com wrote: > Jens, > > Would you have time to answer a question below in this thread? > > On 18.06.2020 11:11, javier.g...@samsung.com wrote: >> On 18.06.2020 08:47, Damien Le Moal wrote: >>> On 2020/06/18 17:35, javier.g...@samsung.com wrote: On 18.06

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread Matias Bjørling
On 19/06/2020 11.41, javier.g...@samsung.com wrote: Jens, Would you have time to answer a question below in this thread? On 18.06.2020 11:11, javier.g...@samsung.com wrote: On 18.06.2020 08:47, Damien Le Moal wrote: On 2020/06/18 17:35, javier.g...@samsung.com wrote: On 18.06.2020 07:39, Dam

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-19 Thread javier.g...@samsung.com
Jens, Would you have time to answer a question below in this thread? On 18.06.2020 11:11, javier.g...@samsung.com wrote: On 18.06.2020 08:47, Damien Le Moal wrote: On 2020/06/18 17:35, javier.g...@samsung.com wrote: On 18.06.2020 07:39, Damien Le Moal wrote: On 2020/06/18 2:27, Kanchan Joshi

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-18 Thread javier.g...@samsung.com
On 18.06.2020 08:47, Damien Le Moal wrote: On 2020/06/18 17:35, javier.g...@samsung.com wrote: On 18.06.2020 07:39, Damien Le Moal wrote: On 2020/06/18 2:27, Kanchan Joshi wrote: From: Selvakumar S Introduce three new opcodes for zone-append - IORING_OP_ZONE_APPEND : non-vectord, sim

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-18 Thread Damien Le Moal
On 2020/06/18 17:35, javier.g...@samsung.com wrote: > On 18.06.2020 07:39, Damien Le Moal wrote: >> On 2020/06/18 2:27, Kanchan Joshi wrote: >>> From: Selvakumar S >>> >>> Introduce three new opcodes for zone-append - >>> >>>IORING_OP_ZONE_APPEND : non-vectord, similiar to IORING_OP_WRITE

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-18 Thread javier.g...@samsung.com
On 18.06.2020 07:39, Damien Le Moal wrote: On 2020/06/18 2:27, Kanchan Joshi wrote: From: Selvakumar S Introduce three new opcodes for zone-append - IORING_OP_ZONE_APPEND : non-vectord, similiar to IORING_OP_WRITE IORING_OP_ZONE_APPENDV: vectored, similar to IORING_OP_WRITEV

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-18 Thread Damien Le Moal
On 2020/06/18 2:27, Kanchan Joshi wrote: > From: Selvakumar S > > Introduce three new opcodes for zone-append - > >IORING_OP_ZONE_APPEND : non-vectord, similiar to IORING_OP_WRITE >IORING_OP_ZONE_APPENDV: vectored, similar to IORING_OP_WRITEV >IORING_OP_ZONE_APPEND_FIXED : ap

Re: [PATCH 3/3] io_uring: add support for zone-append

2020-06-17 Thread Pavel Begunkov
On 17/06/2020 20:23, Kanchan Joshi wrote: > From: Selvakumar S > > Introduce three new opcodes for zone-append - > >IORING_OP_ZONE_APPEND : non-vectord, similiar to IORING_OP_WRITE >IORING_OP_ZONE_APPENDV: vectored, similar to IORING_OP_WRITEV >IORING_OP_ZONE_APPEND_FIXED : a

[PATCH 3/3] io_uring: add support for zone-append

2020-06-17 Thread Kanchan Joshi
From: Selvakumar S Introduce three new opcodes for zone-append - IORING_OP_ZONE_APPEND : non-vectord, similiar to IORING_OP_WRITE IORING_OP_ZONE_APPENDV: vectored, similar to IORING_OP_WRITEV IORING_OP_ZONE_APPEND_FIXED : append using fixed-buffers Repurpose cqe->flags to retur