Re: [PATCH 3/3] kunit: tool: move kunitconfig parsing into __init__

2020-12-04 Thread David Gow
On Sat, Dec 5, 2020 at 2:18 AM Daniel Latypov wrote: > > On Thu, Dec 3, 2020 at 7:57 PM David Gow wrote: > > > > On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote: > > > > > > LinuxSourceTree will unceremoniously crash if the user doesn't call > > > read_kunitconfig() first in a number of func

Re: [PATCH 3/3] kunit: tool: move kunitconfig parsing into __init__

2020-12-04 Thread Daniel Latypov
On Thu, Dec 3, 2020 at 7:57 PM David Gow wrote: > > On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote: > > > > LinuxSourceTree will unceremoniously crash if the user doesn't call > > read_kunitconfig() first in a number of functions. > > This patch seems to partly be reverting the changes here,

Re: [PATCH 3/3] kunit: tool: move kunitconfig parsing into __init__

2020-12-03 Thread David Gow
On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote: > > LinuxSourceTree will unceremoniously crash if the user doesn't call > read_kunitconfig() first in a number of functions. This patch seems to partly be reverting the changes here, right: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/

[PATCH 3/3] kunit: tool: move kunitconfig parsing into __init__

2020-12-03 Thread Daniel Latypov
LinuxSourceTree will unceremoniously crash if the user doesn't call read_kunitconfig() first in a number of functions. Adn currently every place we create an instance, the caller also calls create_kunitconfig() and read_kunitconfig(). Move these instead into __init__() so they can't be forgotten