Re: [PATCH 3/3] lockdep: new annotation lock_downgrade()

2017-02-14 Thread Peter Zijlstra
On Fri, Feb 03, 2017 at 06:05:31AM +0900, J. R. Okajima wrote: > Peter Zijlstra: > > > >> kernel/locking/rwsem.c:126:2: error: implicit declaration of functi= > on 'lock_downgrade' [-Werror=3Dimplicit-function-declaration] > > > lock_downgrade(&sem->dep_map, _RET_IP_); > > > ^

Re: [PATCH 3/3] lockdep: new annotation lock_downgrade()

2017-02-02 Thread J. R. Okajima
Peter Zijlstra: > > >> kernel/locking/rwsem.c:126:2: error: implicit declaration of functi= on 'lock_downgrade' [-Werror=3Dimplicit-function-declaration] > > lock_downgrade(&sem->dep_map, _RET_IP_); > > ^~ ::: > This is what you need !LOCKDEP stubs for ;-) Ok, here is

Re: [PATCH 3/3] lockdep: new annotation lock_downgrade()

2017-02-02 Thread Peter Zijlstra
On Fri, Feb 03, 2017 at 01:59:37AM +0800, kbuild test robot wrote: > Hi Okajima, > > [auto build test ERROR on tip/locking/core] > [also build test ERROR on v4.10-rc6 next-20170202] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url:

Re: [PATCH 3/3] lockdep: new annotation lock_downgrade()

2017-02-02 Thread kbuild test robot
Hi Okajima, [auto build test ERROR on tip/locking/core] [also build test ERROR on v4.10-rc6 next-20170202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/J-R-Okajima/lockdep-consolidate-by-new-f

[PATCH 3/3] lockdep: new annotation lock_downgrade()

2017-02-02 Thread J. R. Okajima
The commit f831948 2016-11-30 locking/lockdep: Provide a type check for lock_is_held didn't fully support rwsem. Here downgrade_write() supports the added type. Originally-written-by: Peter Zijlstra See-also: http://marc.info/?l=linux-kernel&m=148581164003149&w=2 Signed-off-by: J. R. Oka