Re: [PATCH 3/3] media: imx214: Add new control with V4L2_CID_PIXEL_SIZE

2019-08-21 Thread Jacopo Mondi
Hi Ricardo, On Wed, Aug 21, 2019 at 06:31:05PM +0200, Ricardo Ribalda Delgado wrote: > Hi Jacopo > > > On Wed, Aug 21, 2019 at 6:14 PM Jacopo Mondi wrote: > > > > Hi Ricardo, > > > > On Mon, Aug 19, 2019 at 02:17:20PM +0200, Ricardo Ribalda Delgado wrote: > > > According to the product brief, the

Re: [PATCH 3/3] media: imx214: Add new control with V4L2_CID_PIXEL_SIZE

2019-08-21 Thread Jacopo Mondi
Hi Ricardo, On Mon, Aug 19, 2019 at 02:17:20PM +0200, Ricardo Ribalda Delgado wrote: > According to the product brief, the unit cell size is 1120 nanometers^2. Should this information come from DT ? I'm asking as I've a series in review that adds an helper that collectes dt properties and regist

Re: [PATCH 3/3] media: imx214: Add new control with V4L2_CID_PIXEL_SIZE

2019-08-21 Thread Ricardo Ribalda Delgado
Hi Jacopo On Wed, Aug 21, 2019 at 6:14 PM Jacopo Mondi wrote: > > Hi Ricardo, > > On Mon, Aug 19, 2019 at 02:17:20PM +0200, Ricardo Ribalda Delgado wrote: > > According to the product brief, the unit cell size is 1120 nanometers^2. > > Should this information come from DT ? I do not think so. Y

[PATCH 3/3] media: imx214: Add new control with V4L2_CID_PIXEL_SIZE

2019-08-19 Thread Ricardo Ribalda Delgado
According to the product brief, the unit cell size is 1120 nanometers^2. https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 23 +++ 1 file changed, 23 ins