Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-04-01 Thread Matthias Schiffer
On Thu, 2021-04-01 at 09:04 +0100, Lee Jones wrote: > On Wed, 31 Mar 2021, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer > > wrote: > > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > > > >

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-04-01 Thread Lee Jones
On Wed, 31 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer > wrote: > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > > > wrote: > > ... > > > > > + return 24000; > > > > >

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Andy Shevchenko
On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer wrote: > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > > wrote: ... > > > + return 24000; > > > > AFAICS it will return 24 MHz for "Unknown" board. Is it okay to

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > wrote: > > > > All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as > > a default instead of listing each new module individually. > > ... > > > case

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Andy Shevchenko
On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer wrote: > > All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as > a default instead of listing each new module individually. ... > case TQMX86_REG_BOARD_ID_90UC: > return "TQMx90UC"; > + case

[PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-03-31 Thread Matthias Schiffer
All future TQMx86 SoMs will use a 24MHz LPC clock, so we can use that as a default instead of listing each new module individually. Signed-off-by: Matthias Schiffer --- drivers/mfd/tqmx86.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/tqmx86.c