Re: [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()

2020-12-18 Thread NeilBrown
On Fri, Dec 18 2020, Jeffrey Layton wrote: > > The patch we're discussing here _does_ add a f_op->syncfs, which is why > I was suggesting to do it that way. I haven't thought through the issues to decide what I think of adding a new op, but I already know what I think of adding ->syncfs. Don't

Re: [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()

2020-12-18 Thread Jeffrey Layton
On Fri, Dec 18, 2020 at 11:28:19AM -0500, Vivek Goyal wrote: > On Fri, Dec 18, 2020 at 10:02:58AM -0500, Jeff Layton wrote: > > On Fri, Dec 18, 2020 at 09:44:18AM -0500, Vivek Goyal wrote: > > > On Thu, Dec 17, 2020 at 03:08:56PM -0500, Jeffrey Layton wrote: > > > > On Wed, Dec 16, 2020 at

Re: [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()

2020-12-18 Thread Vivek Goyal
On Fri, Dec 18, 2020 at 10:02:58AM -0500, Jeff Layton wrote: > On Fri, Dec 18, 2020 at 09:44:18AM -0500, Vivek Goyal wrote: > > On Thu, Dec 17, 2020 at 03:08:56PM -0500, Jeffrey Layton wrote: > > > On Wed, Dec 16, 2020 at 06:31:49PM -0500, Vivek Goyal wrote: > > > > Check for writeback error on

Re: [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()

2020-12-18 Thread Jeff Layton
On Fri, Dec 18, 2020 at 09:44:18AM -0500, Vivek Goyal wrote: > On Thu, Dec 17, 2020 at 03:08:56PM -0500, Jeffrey Layton wrote: > > On Wed, Dec 16, 2020 at 06:31:49PM -0500, Vivek Goyal wrote: > > > Check for writeback error on overlay super block w.r.t "struct file" > > > passed in ->syncfs(). > >

Re: [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()

2020-12-18 Thread Vivek Goyal
On Thu, Dec 17, 2020 at 03:08:56PM -0500, Jeffrey Layton wrote: > On Wed, Dec 16, 2020 at 06:31:49PM -0500, Vivek Goyal wrote: > > Check for writeback error on overlay super block w.r.t "struct file" > > passed in ->syncfs(). > > > > As of now real error happens on upper sb. So this patch first

Re: [PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()

2020-12-17 Thread Jeffrey Layton
On Wed, Dec 16, 2020 at 06:31:49PM -0500, Vivek Goyal wrote: > Check for writeback error on overlay super block w.r.t "struct file" > passed in ->syncfs(). > > As of now real error happens on upper sb. So this patch first propagates > error from upper sb to overlay sb and then checks error w.r.t

[PATCH 3/3] overlayfs: Check writeback errors w.r.t upper in ->syncfs()

2020-12-16 Thread Vivek Goyal
Check for writeback error on overlay super block w.r.t "struct file" passed in ->syncfs(). As of now real error happens on upper sb. So this patch first propagates error from upper sb to overlay sb and then checks error w.r.t struct file passed in. Jeff, I know you prefer that I should rather