Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-17 Thread Alex Williamson
On Tue, 2013-12-17 at 15:24 -0700, Bjorn Helgaas wrote: > On Tue, Dec 17, 2013 at 3:12 PM, Alex Williamson > wrote: > > On Mon, 2013-12-16 at 17:48 -0700, Bjorn Helgaas wrote: > >> On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: > > >> > +static void pci_vc_load_arb_table(struct

Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-17 Thread Bjorn Helgaas
On Tue, Dec 17, 2013 at 3:12 PM, Alex Williamson wrote: > On Mon, 2013-12-16 at 17:48 -0700, Bjorn Helgaas wrote: >> On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: >> > +static void pci_vc_load_arb_table(struct pci_dev *dev, int pos) >> > +{ >> > + u32 ctrl; >> > + >> > + pc

Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-17 Thread Bjorn Helgaas
On Tue, Dec 17, 2013 at 3:12 PM, Alex Williamson wrote: > On Mon, 2013-12-16 at 17:48 -0700, Bjorn Helgaas wrote: >> On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: >> > +static void pci_vc_load_arb_table(struct pci_dev *dev, int pos) >> > +{ >> > + u32 ctrl; >> > + >> > + pc

Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-17 Thread Alex Williamson
On Mon, 2013-12-16 at 17:48 -0700, Bjorn Helgaas wrote: > On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: > > While we don't really have any infrastructure for making use of VC > > support, the system BIOS can configure the topology to non-default > > VC values prior to boot. This

Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-17 Thread Bjorn Helgaas
On Tue, Dec 17, 2013 at 1:28 PM, Alex Williamson wrote: > On Tue, 2013-12-17 at 11:03 -0700, Bjorn Helgaas wrote: >> On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: >> >... >> > + pci_read_config_dword(dev->bus->self, pos2 + PCI_VC_PORT_REG1, ®1); >> > + evcc = reg1 & PCI_VC_R

Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-17 Thread Alex Williamson
On Tue, 2013-12-17 at 11:03 -0700, Bjorn Helgaas wrote: > On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: > >... > > + pci_read_config_dword(dev->bus->self, pos2 + PCI_VC_PORT_REG1, ®1); > > + evcc = reg1 & PCI_VC_REG1_EVCC; > > I think PCI_VC_PORT_REG1 and PCI_VC_PORT_REG2 ar

Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-17 Thread Bjorn Helgaas
On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: >... > + pci_read_config_dword(dev->bus->self, pos2 + PCI_VC_PORT_REG1, ®1); > + evcc = reg1 & PCI_VC_REG1_EVCC; I think PCI_VC_PORT_REG1 and PCI_VC_PORT_REG2 are mis-named and should be changed to CAP1 and CAP2 or similar.

Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-16 Thread Bjorn Helgaas
On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: > While we don't really have any infrastructure for making use of VC > support, the system BIOS can configure the topology to non-default > VC values prior to boot. This may be due to silicon bugs, desire to > reserve traffic classes

[PATCH 3/3] pci: Add Virtual Channel to save/restore support

2013-12-10 Thread Alex Williamson
While we don't really have any infrastructure for making use of VC support, the system BIOS can configure the topology to non-default VC values prior to boot. This may be due to silicon bugs, desire to reserve traffic classes, or perhaps just BIOS bugs. When we reset devices, the VC configuration