Re: [PATCH 3/3] perf, tools, report: Set up samples correctly in hierarchy mode

2019-03-13 Thread Jiri Olsa
On Tue, Mar 12, 2019 at 06:52:30AM -0700, Andi Kleen wrote: > On Tue, Mar 12, 2019 at 12:12:59PM +0100, Jiri Olsa wrote: > > On Mon, Mar 11, 2019 at 08:52:24PM -0700, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > In hierarchy mode the res samples need to be cloned from the parent > > >

Re: [PATCH 3/3] perf, tools, report: Set up samples correctly in hierarchy mode

2019-03-12 Thread Andi Kleen
On Tue, Mar 12, 2019 at 12:12:59PM +0100, Jiri Olsa wrote: > On Mon, Mar 11, 2019 at 08:52:24PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > In hierarchy mode the res samples need to be cloned from the parent > > entry. Copy them in this case. This fixes res sample browsing > > with

Re: [PATCH 3/3] perf, tools, report: Set up samples correctly in hierarchy mode

2019-03-12 Thread Jiri Olsa
On Mon, Mar 11, 2019 at 08:52:24PM -0700, Andi Kleen wrote: > From: Andi Kleen > > In hierarchy mode the res samples need to be cloned from the parent > entry. Copy them in this case. This fixes res sample browsing > with --hierarchy. > > Signed-off-by: Andi Kleen > --- >

[PATCH 3/3] perf, tools, report: Set up samples correctly in hierarchy mode

2019-03-11 Thread Andi Kleen
From: Andi Kleen In hierarchy mode the res samples need to be cloned from the parent entry. Copy them in this case. This fixes res sample browsing with --hierarchy. Signed-off-by: Andi Kleen --- tools/perf/util/hist.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff