Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-13 Thread Stephane Eranian
On Tue, Aug 13, 2013 at 8:29 AM, Yan, Zheng wrote: > From: "Yan, Zheng" > > This patch adds support for the SNB-EP PCU uncore PMU extra_sel_bit > (bit 21) which is missing from the documentation in Table-2.75 of > Intel Xeon Processor E5-2600 Product Family Uncore Performance > Monitoring Guide.

[PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-13 Thread Yan, Zheng
From: "Yan, Zheng" This patch adds support for the SNB-EP PCU uncore PMU extra_sel_bit (bit 21) which is missing from the documentation in Table-2.75 of Intel Xeon Processor E5-2600 Product Family Uncore Performance Monitoring Guide. It is referred to later in Table-2.81. Without this selection

[PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-13 Thread Yan, Zheng
From: Yan, Zheng zheng.z@intel.com This patch adds support for the SNB-EP PCU uncore PMU extra_sel_bit (bit 21) which is missing from the documentation in Table-2.75 of Intel Xeon Processor E5-2600 Product Family Uncore Performance Monitoring Guide. It is referred to later in Table-2.81.

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-13 Thread Stephane Eranian
On Tue, Aug 13, 2013 at 8:29 AM, Yan, Zheng zheng.z@intel.com wrote: From: Yan, Zheng zheng.z@intel.com This patch adds support for the SNB-EP PCU uncore PMU extra_sel_bit (bit 21) which is missing from the documentation in Table-2.75 of Intel Xeon Processor E5-2600 Product Family

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Stephane Eranian
Hi, How about: This patch adds support for the SNB-EP PCU uncore PMU extra_sel_bit (bit 21) which is missing from the documentation in Table-2.75 of Intel® Xeon® Processor E5-2600 Product Family Uncore Performance Monitoring Guide. It is referred to later in Table-2.81. Without this selection

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Andi Kleen
On Mon, Aug 12, 2013 at 05:16:32PM +0200, Peter Zijlstra wrote: > On Wed, Aug 07, 2013 at 02:17:25PM +0800, Yan, Zheng wrote: > > From: "Yan, Zheng" > > > > PCU uncore event control register has a undocumented ev_sel_ext bit. > > The bit is needed by Andi's pmu-tools. > > Please provide

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Peter Zijlstra
On Fri, Aug 09, 2013 at 11:53:53AM +0200, Stephane Eranian wrote: > On Wed, Aug 7, 2013 at 8:17 AM, Yan, Zheng wrote: > > > > From: "Yan, Zheng" > > > > PCU uncore event control register has a undocumented ev_sel_ext bit. > > The bit is needed by Andi's pmu-tools. > > > > Signed-off-by: Yan,

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Peter Zijlstra
On Wed, Aug 07, 2013 at 02:17:25PM +0800, Yan, Zheng wrote: > From: "Yan, Zheng" > > PCU uncore event control register has a undocumented ev_sel_ext bit. > The bit is needed by Andi's pmu-tools. Please provide documentation. Andi needing it isn't a good changelog (or even reason). -- To

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Peter Zijlstra
On Wed, Aug 07, 2013 at 02:17:25PM +0800, Yan, Zheng wrote: From: Yan, Zheng zheng.z@intel.com PCU uncore event control register has a undocumented ev_sel_ext bit. The bit is needed by Andi's pmu-tools. Please provide documentation. Andi needing it isn't a good changelog (or even

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Peter Zijlstra
On Fri, Aug 09, 2013 at 11:53:53AM +0200, Stephane Eranian wrote: On Wed, Aug 7, 2013 at 8:17 AM, Yan, Zheng zheng.z@intel.com wrote: From: Yan, Zheng zheng.z@intel.com PCU uncore event control register has a undocumented ev_sel_ext bit. The bit is needed by Andi's pmu-tools.

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Andi Kleen
On Mon, Aug 12, 2013 at 05:16:32PM +0200, Peter Zijlstra wrote: On Wed, Aug 07, 2013 at 02:17:25PM +0800, Yan, Zheng wrote: From: Yan, Zheng zheng.z@intel.com PCU uncore event control register has a undocumented ev_sel_ext bit. The bit is needed by Andi's pmu-tools. Please provide

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-12 Thread Stephane Eranian
Hi, How about: This patch adds support for the SNB-EP PCU uncore PMU extra_sel_bit (bit 21) which is missing from the documentation in Table-2.75 of Intel® Xeon® Processor E5-2600 Product Family Uncore Performance Monitoring Guide. It is referred to later in Table-2.81. Without this selection

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-09 Thread Stephane Eranian
On Wed, Aug 7, 2013 at 8:17 AM, Yan, Zheng wrote: > > From: "Yan, Zheng" > > PCU uncore event control register has a undocumented ev_sel_ext bit. > The bit is needed by Andi's pmu-tools. > > Signed-off-by: Yan, Zheng Works for me. Is also needed by libpfm4 uncore PCU events. Now results make

Re: [PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-09 Thread Stephane Eranian
On Wed, Aug 7, 2013 at 8:17 AM, Yan, Zheng zheng.z@intel.com wrote: From: Yan, Zheng zheng.z@intel.com PCU uncore event control register has a undocumented ev_sel_ext bit. The bit is needed by Andi's pmu-tools. Signed-off-by: Yan, Zheng zheng.z@intel.com Works for me. Is also

[PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-07 Thread Yan, Zheng
From: "Yan, Zheng" PCU uncore event control register has a undocumented ev_sel_ext bit. The bit is needed by Andi's pmu-tools. Signed-off-by: Yan, Zheng --- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 2 +- arch/x86/kernel/cpu/perf_event_intel_uncore.h | 1 + 2 files changed, 2

[PATCH 3/3] perf, uncore: enable ev_sel_ext bit for PCU.

2013-08-07 Thread Yan, Zheng
From: Yan, Zheng zheng.z@intel.com PCU uncore event control register has a undocumented ev_sel_ext bit. The bit is needed by Andi's pmu-tools. Signed-off-by: Yan, Zheng zheng.z@intel.com --- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 2 +-