Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-19 Thread Namhyung Kim
On Tue, 19 Aug 2014 09:10:24 +0200, Jiri Olsa wrote: > On Tue, Aug 19, 2014 at 02:51:31PM +0900, Namhyung Kim wrote: > SNIP > >> IMHO, it's harder to find out the right info. Even if we might add >> self/children tag to the callchains, I still think it'd be better just >> to trim down irrelavant i

Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-19 Thread Jiri Olsa
On Tue, Aug 19, 2014 at 02:51:31PM +0900, Namhyung Kim wrote: SNIP > IMHO, it's harder to find out the right info. Even if we might add > self/children tag to the callchains, I still think it'd be better just > to trim down irrelavant info from the output. > > After applying this patch, it'll on

Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-18 Thread Namhyung Kim
Hi Jiri, On Mon, 18 Aug 2014 13:31:47 +0200, Jiri Olsa wrote: > On Sat, Aug 16, 2014 at 11:26:31AM +0900, Namhyung Kim wrote: > > SNIP > >> > >> > hum, where is it callee/caller mixed? with following example: >> > >> > --- >> > void c(void) >> > { >> > } >> > >> > void b(void) >> > { >> >

Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-18 Thread Jiri Olsa
On Sat, Aug 16, 2014 at 11:26:31AM +0900, Namhyung Kim wrote: SNIP > > > > hum, where is it callee/caller mixed? with following example: > > > > --- > > void c(void) > > { > > } > > > > void b(void) > > { > > c(); > > } > > > > void a(void) > > { > > b(); > > } > > > > int m

Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-15 Thread Namhyung Kim
2014-08-15 (금), 21:51 +0200, Jiri Olsa: > On Fri, Aug 15, 2014 at 10:57:14AM +0900, Namhyung Kim wrote: > > Hi Jiri, > > > > 2014-08-14 (목), 16:10 +0200, Jiri Olsa: > > > On Thu, Aug 14, 2014 at 03:01:40PM +0900, Namhyung Kim wrote: > > > > > > SNIP > > > > > > > However, with --children feature

Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-15 Thread Jiri Olsa
On Fri, Aug 15, 2014 at 10:57:14AM +0900, Namhyung Kim wrote: > Hi Jiri, > > 2014-08-14 (목), 16:10 +0200, Jiri Olsa: > > On Thu, Aug 14, 2014 at 03:01:40PM +0900, Namhyung Kim wrote: > > > > SNIP > > > > > However, with --children feature added, it now can show all callees of > > > the entry. F

Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-14 Thread Namhyung Kim
Hi Jiri, 2014-08-14 (목), 16:10 +0200, Jiri Olsa: > On Thu, Aug 14, 2014 at 03:01:40PM +0900, Namhyung Kim wrote: > > SNIP > > > However, with --children feature added, it now can show all callees of > > the entry. For example, "start_kernel" entry now can display it calls > > rest_init and in t

Re: [PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-14 Thread Jiri Olsa
On Thu, Aug 14, 2014 at 03:01:40PM +0900, Namhyung Kim wrote: SNIP > However, with --children feature added, it now can show all callees of > the entry. For example, "start_kernel" entry now can display it calls > rest_init and in turn cpu_idle and then cpuidle_idle_call (95.72%). > > 6.14

[PATCH 3/3] perf callchain: Prune misleading callchains for self entries

2014-08-13 Thread Namhyung Kim
The "perf report -g" displays callchains callee-first order. That means it can see the callers of the sample in a reverse order. For example, "intel_idle" entry shows following callchain on my data. Children Self Command Shared Object Symbol -