Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

2020-09-17 Thread Jiri Olsa
On Thu, Sep 17, 2020 at 10:27:41AM +0900, Namhyung Kim wrote: > On Wed, Sep 16, 2020 at 5:24 PM Jiri Olsa wrote: > > > > On Tue, Sep 15, 2020 at 11:55:34PM +0900, Namhyung Kim wrote: > > > On Tue, Sep 15, 2020 at 7:05 PM Jiri Olsa wrote: > > > > > > > > On Mon, Sep 14, 2020 at 11:18:59PM +0900, N

Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

2020-09-16 Thread Namhyung Kim
On Tue, Sep 15, 2020 at 7:05 PM Jiri Olsa wrote: > > On Mon, Sep 14, 2020 at 11:18:59PM +0900, Namhyung Kim wrote: > > @@ -478,19 +479,8 @@ static int perf_event__inject_buildid(struct perf_tool > > *tool, > > if (thread__find_map(thread, sample->cpumode, sample->ip, &al)) { > >

Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

2020-09-16 Thread Namhyung Kim
On Wed, Sep 16, 2020 at 5:24 PM Jiri Olsa wrote: > > On Tue, Sep 15, 2020 at 11:55:34PM +0900, Namhyung Kim wrote: > > On Tue, Sep 15, 2020 at 7:05 PM Jiri Olsa wrote: > > > > > > On Mon, Sep 14, 2020 at 11:18:59PM +0900, Namhyung Kim wrote: > > > > No need to load symbols in a DSO when injecting

Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

2020-09-16 Thread Jiri Olsa
On Tue, Sep 15, 2020 at 11:55:34PM +0900, Namhyung Kim wrote: > On Tue, Sep 15, 2020 at 7:05 PM Jiri Olsa wrote: > > > > On Mon, Sep 14, 2020 at 11:18:59PM +0900, Namhyung Kim wrote: > > > No need to load symbols in a DSO when injecting build-id. I guess the > > > reason was to check the DSO is a

Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

2020-09-15 Thread Namhyung Kim
On Tue, Sep 15, 2020 at 7:05 PM Jiri Olsa wrote: > > On Mon, Sep 14, 2020 at 11:18:59PM +0900, Namhyung Kim wrote: > > No need to load symbols in a DSO when injecting build-id. I guess the > > reason was to check the DSO is a special file like anon files. Use > > some helper functions in map.c t

Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

2020-09-15 Thread Jiri Olsa
On Mon, Sep 14, 2020 at 11:18:59PM +0900, Namhyung Kim wrote: > No need to load symbols in a DSO when injecting build-id. I guess the > reason was to check the DSO is a special file like anon files. Use > some helper functions in map.c to check them before reading build-id. > Also pass sample eve

[PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

2020-09-14 Thread Namhyung Kim
No need to load symbols in a DSO when injecting build-id. I guess the reason was to check the DSO is a special file like anon files. Use some helper functions in map.c to check them before reading build-id. Also pass sample event's cpumode to a new build-id event. Original-patch-by: Stephane Era