Re: [PATCH 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use

2020-11-17 Thread Amjad Ouled-Ameur
Hi Martin, Thank you for the review ! On 14/11/2020 20:11, Martin Blumenstingl wrote: Hi Amjad, On Fri, Nov 13, 2020 at 1:07 AM Amjad Ouled-Ameur wrote: [...] ret = clk_prepare_enable(priv->clk_usb); if (ret) { dev_err(&phy->dev, "Failed to enable USB DDR

Re: [PATCH 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use

2020-11-14 Thread Martin Blumenstingl
Hi Amjad, On Fri, Nov 13, 2020 at 1:07 AM Amjad Ouled-Ameur wrote: [...] > ret = clk_prepare_enable(priv->clk_usb); > if (ret) { > dev_err(&phy->dev, "Failed to enable USB DDR clock\n"); > + reset_control_rearm(priv->reset); this should come after res

[PATCH 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use

2020-11-12 Thread Amjad Ouled-Ameur
Use reset_control_rearm() call if an error occurs in case phy_meson8b_usb2_power_on() fails after reset() has been called, or in case phy_meson8b_usb2_power_off() is called i.e the resource is no longer used and the reset line may be triggered again by other devices. reset_control_rearm() keeps us