RE: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Kukjin Kim
Doug Anderson wrote: > > Kukjin > > > Oops, sorry. > On Thu, Jun 13, 2013 at 4:13 PM, Kukjin Kim wrote: > > Doug Anderson wrote: > >> > >> Tomasz, > >> > >> On Thu, Jun 13, 2013 at 9:42 AM, Tomasz Figa > wrote: > >> >> > BTW, probably we need a similar fixing in the mach-exynos/common.c > >>

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Doug Anderson
Kukjin On Thu, Jun 13, 2013 at 4:13 PM, Kukjin Kim wrote: > Doug Anderson wrote: >> >> Tomasz, >> >> On Thu, Jun 13, 2013 at 9:42 AM, Tomasz Figa wrote: >> >> > BTW, probably we need a similar fixing in the mach-exynos/common.c >> >> > file >> >> > before pinct기 for distro... >> >> >> >> Is an

RE: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Kukjin Kim
Doug Anderson wrote: > > Tomasz, > > On Thu, Jun 13, 2013 at 9:42 AM, Tomasz Figa wrote: > >> > BTW, probably we need a similar fixing in the mach-exynos/common.c > >> > file > >> > before pinct기 for distro... > >> > >> Is anyone using the functions in mach-exynos/common.c file anymore? I > >>

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Doug Anderson
Tomasz, On Thu, Jun 13, 2013 at 9:42 AM, Tomasz Figa wrote: >> > BTW, probably we need a similar fixing in the mach-exynos/common.c >> > file >> > before pinct기 for distro... >> >> Is anyone using the functions in mach-exynos/common.c file anymore? I >> thought that non-dt exynos support was goi

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 09:38:33 Doug Anderson wrote: > Kukjin, > > On Thu, Jun 13, 2013 at 5:04 AM, Kukjin Kim wrote: > > Doug Anderson wrote: > >> A level-triggered interrupt should be acked after the interrupt line > >> becomes inactive and before it is unmasked, or else another interrupt

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 09:34:43 Doug Anderson wrote: > Tomasz, > > On Thu, Jun 13, 2013 at 3:54 AM, Tomasz Figa wrote: > > Hi Doug, > > > > On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: > >> A level-triggered interrupt should be acked after the interrupt line > >> becomes inac

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Doug Anderson
Kukjin, On Thu, Jun 13, 2013 at 5:04 AM, Kukjin Kim wrote: > Doug Anderson wrote: >> >> A level-triggered interrupt should be acked after the interrupt line >> becomes inactive and before it is unmasked, or else another interrupt >> will be immediately triggered. Acking before or after calling t

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Doug Anderson
Tomasz, On Thu, Jun 13, 2013 at 3:54 AM, Tomasz Figa wrote: > Hi Doug, > > On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: >> A level-triggered interrupt should be acked after the interrupt line >> becomes inactive and before it is unmasked, or else another interrupt >> will be immedia

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Linus Walleij
On Wed, Jun 12, 2013 at 7:33 PM, Doug Anderson wrote: > A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not enough. > > Si

RE: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Kukjin Kim
Doug Anderson wrote: > > A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not enough. > > Signed-off-by: Luigi Semenzato >

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
Hi Doug, On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: > A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not e

[PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-12 Thread Doug Anderson
A level-triggered interrupt should be acked after the interrupt line becomes inactive and before it is unmasked, or else another interrupt will be immediately triggered. Acking before or after calling the handler is not enough. Signed-off-by: Luigi Semenzato Signed-off-by: Doug Anderson --- dr