Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-09 Thread Pali Rohár
> > Cc: y.li...@paritcher.com; linux-kernel@vger.kernel.org; platform-driver- > > x...@vger.kernel.org; mj...@srcf.ucam.org > > Subject: Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to > > bios_to_linux_keycode > > > > > > [EXTERNAL EMAIL] > >

RE: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-08 Thread Mario.Limonciello
.@vger.kernel.org; mj...@srcf.ucam.org > Subject: Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to > bios_to_linux_keycode > > > [EXTERNAL EMAIL] > > On Monday 08 June 2020 15:46:44 mario.limoncie...@dell.com wrote: > > I would actually question if there is value to

Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-08 Thread Pali Rohár
On Monday 08 June 2020 15:46:44 mario.limoncie...@dell.com wrote: > I would actually question if there is value to lines in dell-wmi.c like this: > > pr_info("Unknown WMI event type 0x%x\n", (int)buffer_entry[1]); > > and > > pr_info("Unknown key with type 0x%04x and code 0x%04x pressed\n", type

Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-08 Thread Y Paritcher
nel@vger.kernel.org; platform-driver-...@vger.kernel.org; >> Matthew Garrett >> Subject: Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to >> bios_to_linux_keycode >> >> >> [EXTERNAL EMAIL] >> >> Hello! >> >> On Monday 08 June 2020 00:22:

RE: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-08 Thread Mario.Limonciello
Subject: Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to > bios_to_linux_keycode > > > [EXTERNAL EMAIL] > > Hello! > > On Monday 08 June 2020 00:22:26 Y Paritcher wrote: > > Increase length of bios_to_linux_keycode to 2 bytes to allow for a new > > keyco

Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-08 Thread Pali Rohár
Hello! On Monday 08 June 2020 00:22:26 Y Paritcher wrote: > Increase length of bios_to_linux_keycode to 2 bytes to allow for a new > keycode 0x, this silences the following messages being logged at > startup on a Dell Inspiron 5593 > > dell_wmi: firmware scancode 0x48 maps to unrecognized key

Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-08 Thread kernel test robot
Hi Paritcher, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/auto-latest] [also build test WARNING on platform-drivers-x86/for-next linus/master v5.7 next-20200605] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-08 Thread kernel test robot
Hi Paritcher, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/auto-latest] [also build test WARNING on platform-drivers-x86/for-next linus/master linux/master v5.7 next-20200605] [if your patch is applied to the wrong git tree, please drop us a note to help

[PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

2020-06-07 Thread Y Paritcher
Increase length of bios_to_linux_keycode to 2 bytes to allow for a new keycode 0x, this silences the following messages being logged at startup on a Dell Inspiron 5593 dell_wmi: firmware scancode 0x48 maps to unrecognized keycode 0x dell_wmi: firmware scancode 0x50 maps to unrecognized key