Re: [PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-05-04 Thread kbuild test robot
Hi Wesley, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v4.17-rc3] [cannot apply to next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-05-04 Thread kbuild test robot
Hi Wesley, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v4.17-rc3] [cannot apply to next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-04-30 Thread Wesley Terpstra
First of all, thank you very much for this detailed review! I really appreciate it, as this is just the first driver of several we would like to upstream and getting the reviews front-loaded like this will really help us improve the subsequent drivers before trying to upstream them. On Mon, Apr

Re: [PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-04-30 Thread Wesley Terpstra
First of all, thank you very much for this detailed review! I really appreciate it, as this is just the first driver of several we would like to upstream and getting the reviews front-loaded like this will really help us improve the subsequent drivers before trying to upstream them. On Mon, Apr

Re: [PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-04-30 Thread Thierry Reding
On Fri, Apr 27, 2018 at 03:59:58PM -0700, Wesley W. Terpstra wrote: > SiFive SoCs can contain one or more PWM IP blocks. > This adds a driver for them. Tested on the HiFive Unleashed. > > Signed-off-by: Wesley W. Terpstra > --- > drivers/pwm/Kconfig | 11 ++ >

Re: [PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-04-30 Thread Thierry Reding
On Fri, Apr 27, 2018 at 03:59:58PM -0700, Wesley W. Terpstra wrote: > SiFive SoCs can contain one or more PWM IP blocks. > This adds a driver for them. Tested on the HiFive Unleashed. > > Signed-off-by: Wesley W. Terpstra > --- > drivers/pwm/Kconfig | 11 ++ > drivers/pwm/Makefile |

[PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-04-27 Thread Wesley W. Terpstra
SiFive SoCs can contain one or more PWM IP blocks. This adds a driver for them. Tested on the HiFive Unleashed. Signed-off-by: Wesley W. Terpstra --- drivers/pwm/Kconfig | 11 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-sifive.c | 259

[PATCH 3/3] pwm-sifive: add a driver for SiFive SoC PWM

2018-04-27 Thread Wesley W. Terpstra
SiFive SoCs can contain one or more PWM IP blocks. This adds a driver for them. Tested on the HiFive Unleashed. Signed-off-by: Wesley W. Terpstra --- drivers/pwm/Kconfig | 11 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-sifive.c | 259