Re: [PATCH 3/3] rtc: add Cypress FM33256B RTC driver

On 22/04/16 01:44, Alexandre Belloni wrote: > Hi, Hi Alexandre, > Looks mostly good, a few comments below Thanks for the review. I'll add your fixes and send a v2 patch. -Jeppe

Re: [PATCH 3/3] rtc: add Cypress FM33256B RTC driver

On 22/04/16 01:44, Alexandre Belloni wrote: > Hi, Hi Alexandre, > Looks mostly good, a few comments below Thanks for the review. I'll add your fixes and send a v2 patch. -Jeppe

Re: [PATCH 3/3] rtc: add Cypress FM33256B RTC driver

Hi, Looks mostly good, a few comments below On 20/04/2016 at 13:07:51 +0200, Jeppe Ledet-Pedersen wrote : Please always include a commit message. > Signed-off-by: Jeppe Ledet-Pedersen > --- [...] > +static int fm33256b_rtc_readtime(struct device *dev, struct rtc_time *tm)

Re: [PATCH 3/3] rtc: add Cypress FM33256B RTC driver

Hi, Looks mostly good, a few comments below On 20/04/2016 at 13:07:51 +0200, Jeppe Ledet-Pedersen wrote : Please always include a commit message. > Signed-off-by: Jeppe Ledet-Pedersen > --- [...] > +static int fm33256b_rtc_readtime(struct device *dev, struct rtc_time *tm) > +{ > + int

[PATCH 3/3] rtc: add Cypress FM33256B RTC driver

Signed-off-by: Jeppe Ledet-Pedersen --- MAINTAINERS| 1 + drivers/rtc/Kconfig| 10 +++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-fm33256b.c | 166 + 4 files changed, 178 insertions(+) create mode

[PATCH 3/3] rtc: add Cypress FM33256B RTC driver

Signed-off-by: Jeppe Ledet-Pedersen --- MAINTAINERS| 1 + drivers/rtc/Kconfig| 10 +++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-fm33256b.c | 166 + 4 files changed, 178 insertions(+) create mode 100644