Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Krzysztof Kozlowski
On 30.12.2015 12:38, Krzysztof Kozlowski wrote: > On 30.12.2015 11:53, Yadwinder Singh Brar wrote: >> Hi Krysztof, >> >> On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski >> wrote: >>> Before updating time and alarm the driver must set appropriate mask in >>> UDR register. For that purpose the

Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Krzysztof Kozlowski
On 30.12.2015 11:53, Yadwinder Singh Brar wrote: > Hi Krysztof, > > On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski > wrote: >> Before updating time and alarm the driver must set appropriate mask in >> UDR register. For that purpose the driver uses common register >> configuration and a lot

Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Yadwinder Singh Brar
Hi Krysztof, On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski wrote: > Before updating time and alarm the driver must set appropriate mask in > UDR register. For that purpose the driver uses common register > configuration and a lot of exceptions per device in the code. The > exceptions are

[PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Krzysztof Kozlowski
Before updating time and alarm the driver must set appropriate mask in UDR register. For that purpose the driver uses common register configuration and a lot of exceptions per device in the code. The exceptions are not obvious, for example except the change in the logic sometimes the fields are

[PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Krzysztof Kozlowski
Before updating time and alarm the driver must set appropriate mask in UDR register. For that purpose the driver uses common register configuration and a lot of exceptions per device in the code. The exceptions are not obvious, for example except the change in the logic sometimes the fields are

Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Yadwinder Singh Brar
Hi Krysztof, On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski wrote: > Before updating time and alarm the driver must set appropriate mask in > UDR register. For that purpose the driver uses common register > configuration and a lot of exceptions per device in the

Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Krzysztof Kozlowski
On 30.12.2015 11:53, Yadwinder Singh Brar wrote: > Hi Krysztof, > > On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski > wrote: >> Before updating time and alarm the driver must set appropriate mask in >> UDR register. For that purpose the driver uses common register

Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Krzysztof Kozlowski
On 30.12.2015 12:38, Krzysztof Kozlowski wrote: > On 30.12.2015 11:53, Yadwinder Singh Brar wrote: >> Hi Krysztof, >> >> On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski >> wrote: >>> Before updating time and alarm the driver must set appropriate mask in >>> UDR