Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Martin Schwidefsky
On Tue, 27 Nov 2018 08:34:12 +0100 Heiko Carstens wrote: > On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > > Thanks for

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Martin Schwidefsky
On Tue, 27 Nov 2018 08:34:12 +0100 Heiko Carstens wrote: > On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > > Thanks for

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 03:47:13AM -0800, Guenter Roeck wrote: > >E.g. something like the below. If there aren't any objections, I will > >provide a proper patch with changelog, etc. > > > >diff --git a/kernel/fork.c b/kernel/fork.c > >index 07cddff89c7b..d7aeec03c57f 100644 > >--- a/kernel/fork.c

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 03:47:13AM -0800, Guenter Roeck wrote: > >E.g. something like the below. If there aren't any objections, I will > >provide a proper patch with changelog, etc. > > > >diff --git a/kernel/fork.c b/kernel/fork.c > >index 07cddff89c7b..d7aeec03c57f 100644 > >--- a/kernel/fork.c

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Guenter Roeck
On 11/26/18 11:34 PM, Heiko Carstens wrote: On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: Thanks for testing. Unfortunately Heiko reported

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Guenter Roeck
On 11/26/18 11:34 PM, Heiko Carstens wrote: On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: Thanks for testing. Unfortunately Heiko reported

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 11:05:15AM +0300, Kirill A. Shutemov wrote: > > E.g. something like the below. If there aren't any objections, I will > > provide a proper patch with changelog, etc. > > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 07cddff89c7b..d7aeec03c57f 100644 > > ---

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 11:05:15AM +0300, Kirill A. Shutemov wrote: > > E.g. something like the below. If there aren't any objections, I will > > provide a proper patch with changelog, etc. > > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 07cddff89c7b..d7aeec03c57f 100644 > > ---

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Kirill A. Shutemov
On Tue, Nov 27, 2018 at 08:34:12AM +0100, Heiko Carstens wrote: > On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > > Thanks for

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Kirill A. Shutemov
On Tue, Nov 27, 2018 at 08:34:12AM +0100, Heiko Carstens wrote: > On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > > Thanks for

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-26 Thread Heiko Carstens
On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > Thanks for testing. Unfortunately Heiko reported another issue yesterday > > > with

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-26 Thread Heiko Carstens
On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > Thanks for testing. Unfortunately Heiko reported another issue yesterday > > > with

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Kirill A. Shutemov
On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > Thanks for testing. Unfortunately Heiko reported another issue yesterday > > with the patch applied. This time the other way around: > > > > BUG: non-zero

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Kirill A. Shutemov
On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > Thanks for testing. Unfortunately Heiko reported another issue yesterday > > with the patch applied. This time the other way around: > > > > BUG: non-zero

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Heiko Carstens
On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > Thanks for testing. Unfortunately Heiko reported another issue yesterday > with the patch applied. This time the other way around: > > BUG: non-zero pgtables_bytes on freeing mm: -16384 > > I am trying to understand how this

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Heiko Carstens
On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > Thanks for testing. Unfortunately Heiko reported another issue yesterday > with the patch applied. This time the other way around: > > BUG: non-zero pgtables_bytes on freeing mm: -16384 > > I am trying to understand how this

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Martin Schwidefsky
On Wed, 31 Oct 2018 07:46:47 +0100 Martin Schwidefsky wrote: > On Wed, 31 Oct 2018 14:43:38 +0800 > Li Wang wrote: > > > On Wed, Oct 31, 2018 at 2:31 PM, Martin Schwidefsky > > wrote: > > > > > BUG: non-zero pgtables_bytes on freeing mm: -16384 > > > > > > > Okay, the problem is still

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Martin Schwidefsky
On Wed, 31 Oct 2018 07:46:47 +0100 Martin Schwidefsky wrote: > On Wed, 31 Oct 2018 14:43:38 +0800 > Li Wang wrote: > > > On Wed, Oct 31, 2018 at 2:31 PM, Martin Schwidefsky > > wrote: > > > > > BUG: non-zero pgtables_bytes on freeing mm: -16384 > > > > > > > Okay, the problem is still

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Martin Schwidefsky
On Wed, 31 Oct 2018 14:43:38 +0800 Li Wang wrote: > On Wed, Oct 31, 2018 at 2:31 PM, Martin Schwidefsky > wrote: > > > On Wed, 31 Oct 2018 14:18:33 +0800 > > Li Wang wrote: > > > > > On Tue, Oct 16, 2018 at 12:42 AM, Martin Schwidefsky < > > schwidef...@de.ibm.com > > > > wrote: > > >

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Martin Schwidefsky
On Wed, 31 Oct 2018 14:43:38 +0800 Li Wang wrote: > On Wed, Oct 31, 2018 at 2:31 PM, Martin Schwidefsky > wrote: > > > On Wed, 31 Oct 2018 14:18:33 +0800 > > Li Wang wrote: > > > > > On Tue, Oct 16, 2018 at 12:42 AM, Martin Schwidefsky < > > schwidef...@de.ibm.com > > > > wrote: > > >

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Martin Schwidefsky
On Wed, 31 Oct 2018 14:18:33 +0800 Li Wang wrote: > On Tue, Oct 16, 2018 at 12:42 AM, Martin Schwidefsky > wrote: > > > In case a fork or a clone system fails in copy_process and the error > > handling does the mmput() at the bad_fork_cleanup_mm label, the > > following warning messages will

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-31 Thread Martin Schwidefsky
On Wed, 31 Oct 2018 14:18:33 +0800 Li Wang wrote: > On Tue, Oct 16, 2018 at 12:42 AM, Martin Schwidefsky > wrote: > > > In case a fork or a clone system fails in copy_process and the error > > handling does the mmput() at the bad_fork_cleanup_mm label, the > > following warning messages will

[PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-15 Thread Martin Schwidefsky
In case a fork or a clone system fails in copy_process and the error handling does the mmput() at the bad_fork_cleanup_mm label, the following warning messages will appear on the console: BUG: non-zero pgtables_bytes on freeing mm: 16384 The reason for that is the tricks we play with

[PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-10-15 Thread Martin Schwidefsky
In case a fork or a clone system fails in copy_process and the error handling does the mmput() at the bad_fork_cleanup_mm label, the following warning messages will appear on the console: BUG: non-zero pgtables_bytes on freeing mm: 16384 The reason for that is the tricks we play with