Re: [PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-17 Thread Siddharth Gupta
On 1/14/2021 9:46 AM, Bjorn Andersson wrote: On Wed 13 Jan 17:01 CST 2021, Siddharth Gupta wrote: On 1/7/2021 4:21 PM, Bjorn Andersson wrote: On Wed 06 Jan 15:23 CST 2021, Siddharth Gupta wrote: Since the split elf blobs will always contain the hash segment, we rely on I think it will sou

Re: [PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-14 Thread Bjorn Andersson
On Wed 13 Jan 17:01 CST 2021, Siddharth Gupta wrote: > > On 1/7/2021 4:21 PM, Bjorn Andersson wrote: > > On Wed 06 Jan 15:23 CST 2021, Siddharth Gupta wrote: > > > > > Since the split elf blobs will always contain the hash segment, we rely on > > I think it will sounds better if we add "should"

Re: [PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-13 Thread Siddharth Gupta
On 1/7/2021 4:21 PM, Bjorn Andersson wrote: On Wed 06 Jan 15:23 CST 2021, Siddharth Gupta wrote: Since the split elf blobs will always contain the hash segment, we rely on I think it will sounds better if we add "should" in "we should rely on..." Sure the blob file to get the hash rather

Re: [PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-07 Thread Bjorn Andersson
On Wed 06 Jan 15:23 CST 2021, Siddharth Gupta wrote: > Since the split elf blobs will always contain the hash segment, we rely on I think it will sounds better if we add "should" in "we should rely on..." > the blob file to get the hash rather than assume that it will be present in > the mdt fil

Re: [PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-06 Thread kernel test robot
Hi Siddharth, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc2 next-20210104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docu

[PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-06 Thread Siddharth Gupta
Since the split elf blobs will always contain the hash segment, we rely on the blob file to get the hash rather than assume that it will be present in the mdt file. This change uses the hash index to read the appropriate elf blob to get the hash segment. Signed-off-by: Siddharth Gupta --- driver