Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-13 Thread Vinod Koul
On 12-05-20, 12:01, Pierre-Louis Bossart wrote: > > > > > > > > > > > > There isn't any known implementation with more than one controller. > > > > > > > > > > But then it can come in "future" right. So lets try to make it future > > > > > proof by not using the link_id (we can expose that as a

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-12 Thread Pierre-Louis Bossart
On 5/12/20 11:08 AM, Pierre-Louis Bossart wrote: On 5/12/20 10:59 AM, Vinod Koul wrote: On 12-05-20, 09:36, Pierre-Louis Bossart wrote: On 5/11/20 10:30 PM, Vinod Koul wrote: On 11-05-20, 14:00, Pierre-Louis Bossart wrote: +    md = >md; +    md->dev.bus = _bus_type; +    md->dev.type =

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-12 Thread Pierre-Louis Bossart
On 5/12/20 10:59 AM, Vinod Koul wrote: On 12-05-20, 09:36, Pierre-Louis Bossart wrote: On 5/11/20 10:30 PM, Vinod Koul wrote: On 11-05-20, 14:00, Pierre-Louis Bossart wrote: + md = >md; + md->dev.bus = _bus_type; + md->dev.type = _master_type; + md->dev.parent =

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-12 Thread Vinod Koul
On 12-05-20, 09:36, Pierre-Louis Bossart wrote: > On 5/11/20 10:30 PM, Vinod Koul wrote: > > On 11-05-20, 14:00, Pierre-Louis Bossart wrote: > > > > > + md = >md; > > > > > + md->dev.bus = _bus_type; > > > > > + md->dev.type = _master_type; > > > > > + md->dev.parent = parent; > >

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-12 Thread Pierre-Louis Bossart
On 5/11/20 10:30 PM, Vinod Koul wrote: On 11-05-20, 14:00, Pierre-Louis Bossart wrote: + md = >md; + md->dev.bus = _bus_type; + md->dev.type = _master_type; + md->dev.parent = parent; + md->dev.of_node = parent->of_node; + md->dev.fwnode = fwnode; +

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-11 Thread Vinod Koul
On 11-05-20, 14:00, Pierre-Louis Bossart wrote: > > > + md = >md; > > > + md->dev.bus = _bus_type; > > > + md->dev.type = _master_type; > > > + md->dev.parent = parent; > > > + md->dev.of_node = parent->of_node; > > > + md->dev.fwnode = fwnode; > > > + md->dev.dma_mask = parent->dma_mask; > > > +

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-11 Thread Pierre-Louis Bossart
+ md = >md; + md->dev.bus = _bus_type; + md->dev.type = _master_type; + md->dev.parent = parent; + md->dev.of_node = parent->of_node; + md->dev.fwnode = fwnode; + md->dev.dma_mask = parent->dma_mask; + + dev_set_name(>dev, "sdw-master-%d",

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-11 Thread Vinod Koul
naro.org; > > > > rander.w...@linux.intel.com; ranjani.sridha...@linux.intel.com; > > > > hui.w...@canonical.com; pierre- louis.boss...@linux.intel.com; Kale, > > > > Sanyog R ; Blauciak, Slawomir > > > > ; Lin, Mengdong > > > > ; Liao, Bard >

RE: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-11 Thread Liao, Bard
m; > srinivas.kandaga...@linaro.org; rander.w...@linux.intel.com; > ranjani.sridha...@linux.intel.com; hui.w...@canonical.com; pierre- > louis.boss...@linux.intel.com; Kale, Sanyog R ; > Blauciak, Slawomir ; Lin, Mengdong > > Subject: Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_devic

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-11 Thread Vinod Koul
Mengdong > > ; Liao, Bard > > Subject: Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support > > > > On 30-04-20, 02:51, Bard Liao wrote: > > > @@ -24,9 +24,14 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct > > device *parent, > >

RE: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-11 Thread Liao, Bard
@linaro.org; rander.w...@linux.intel.com; > ranjani.sridha...@linux.intel.com; hui.w...@canonical.com; pierre- > louis.boss...@linux.intel.com; Kale, Sanyog R ; > Blauciak, Slawomir ; Lin, Mengdong > ; Liao, Bard > Subject: Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device suppor

Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-05-11 Thread Vinod Koul
On 30-04-20, 02:51, Bard Liao wrote: > @@ -24,9 +24,14 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device > *parent, > struct sdw_master_prop *prop = NULL; > int ret; > > - if (!bus->dev) { > - pr_err("SoundWire bus has no device\n"); > - return

[PATCH 3/3] soundwire: bus_type: add sdw_master_device support

2020-04-30 Thread Bard Liao
From: Pierre-Louis Bossart In the existing SoundWire code, Master Devices are not explicitly represented - only SoundWire Slave Devices are exposed (the use of capital letters follows the SoundWire specification conventions). The SoundWire Master Device provides the clock, synchronization