Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

2014-03-11 Thread Mark Brown
On Tue, Mar 11, 2014 at 02:35:15PM +0100, Geert Uytterhoeven wrote: > On Tue, Mar 11, 2014 at 2:26 PM, Mark Brown wrote: > > On Tue, Mar 11, 2014 at 02:10:31PM +0100, Geert Uytterhoeven wrote: > >> Can you please elaborate what should be fixed? > >> If I disable CONFIG_PM_RUNTIME, the kernel pri

Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

2014-03-11 Thread Geert Uytterhoeven
Hi Mark, On Tue, Mar 11, 2014 at 2:26 PM, Mark Brown wrote: > On Tue, Mar 11, 2014 at 02:10:31PM +0100, Geert Uytterhoeven wrote: > >> Can you please elaborate what should be fixed? > >> If I disable CONFIG_PM_RUNTIME, the kernel prints: > >> Runtime PM disabled, clock forced on. > >> and the

Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

2014-03-11 Thread Mark Brown
On Tue, Mar 11, 2014 at 02:10:31PM +0100, Geert Uytterhoeven wrote: > Can you please elaborate what should be fixed? > If I disable CONFIG_PM_RUNTIME, the kernel prints: > Runtime PM disabled, clock forced on. > and the clock is enabled all the time (verified by looking at the clock > regis

Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

2014-03-11 Thread Geert Uytterhoeven
Hi Mark, On Tue, Mar 11, 2014 at 11:47 AM, Mark Brown wrote: > On Tue, Mar 11, 2014 at 10:59:12AM +0100, Geert Uytterhoeven wrote: >> From: Geert Uytterhoeven > > Applied, thanks, though... > >> - ret = clk_prepare_enable(rspi->clk); >> - if (ret < 0) { >> - dev_err(&pdev->de

Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

2014-03-11 Thread Mark Brown
On Tue, Mar 11, 2014 at 10:59:12AM +0100, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven Applied, thanks, though... > - ret = clk_prepare_enable(rspi->clk); > - if (ret < 0) { > - dev_err(&pdev->dev, "unable to prepare/enable clock\n"); > - goto error1; > -

[PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

2014-03-11 Thread Geert Uytterhoeven
From: Geert Uytterhoeven Signed-off-by: Geert Uytterhoeven --- drivers/spi/spi-rspi.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c index 92bec7e91046..1fb0ad213324 100644 --- a/drivers/spi/spi-rspi.c +++ b/dri