Re: [PATCH 3/3] staging: iio: light: isl29018: add ACPI support

2014-08-30 Thread Jonathan Cameron
On 29/08/14 15:26, Laurentiu Palcu wrote: > Add support for enumerating the device through ACPI. > > Signed-off-by: Laurentiu Palcu Mostly fine, but I'm unclear on why we have a cast to a char * for name. Maybe I just haven't had enough coffee this morning :) Jonathan > --- >

Re: [PATCH 3/3] staging: iio: light: isl29018: add ACPI support

2014-08-30 Thread Jonathan Cameron
On 29/08/14 15:26, Laurentiu Palcu wrote: Add support for enumerating the device through ACPI. Signed-off-by: Laurentiu Palcu laurentiu.pa...@intel.com Mostly fine, but I'm unclear on why we have a cast to a char * for name. Maybe I just haven't had enough coffee this morning :) Jonathan ---

[PATCH 3/3] staging: iio: light: isl29018: add ACPI support

2014-08-29 Thread Laurentiu Palcu
Add support for enumerating the device through ACPI. Signed-off-by: Laurentiu Palcu --- drivers/staging/iio/light/isl29018.c | 46 +++- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c

[PATCH 3/3] staging: iio: light: isl29018: add ACPI support

2014-08-29 Thread Laurentiu Palcu
Add support for enumerating the device through ACPI. Signed-off-by: Laurentiu Palcu laurentiu.pa...@intel.com --- drivers/staging/iio/light/isl29018.c | 46 +++- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c