Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Tue 2016-11-15 08:40:57, Jacob Pan wrote: > On Tue, 15 Nov 2016 19:36:26 +0800 > Zhang Rui wrote: > > > On Mon, 2016-11-14 at 11:12 -0800, Jacob Pan wrote: > > > On Fri, 11 Nov 2016 18:34:10 +0100 > > > Petr Mladek wrote: > > > > > > > > > > >

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Tue 2016-11-15 08:40:57, Jacob Pan wrote: > On Tue, 15 Nov 2016 19:36:26 +0800 > Zhang Rui wrote: > > > On Mon, 2016-11-14 at 11:12 -0800, Jacob Pan wrote: > > > On Fri, 11 Nov 2016 18:34:10 +0100 > > > Petr Mladek wrote: > > > > > > > > > > > Please, let me known if I should do this as

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Tue, 15 Nov 2016 19:36:26 +0800 Zhang Rui wrote: > On Mon, 2016-11-14 at 11:12 -0800, Jacob Pan wrote: > > On Fri, 11 Nov 2016 18:34:10 +0100 > > Petr Mladek wrote: > > > > > > > > Please, let me known if I should do this as a separate patch > > >

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Tue, 15 Nov 2016 19:36:26 +0800 Zhang Rui wrote: > On Mon, 2016-11-14 at 11:12 -0800, Jacob Pan wrote: > > On Fri, 11 Nov 2016 18:34:10 +0100 > > Petr Mladek wrote: > > > > > > > > Please, let me known if I should do this as a separate patch > > > and/or resend the patchset. > >

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon, 2016-11-14 at 11:12 -0800, Jacob Pan wrote: > On Fri, 11 Nov 2016 18:34:10 +0100 > Petr Mladek wrote: > > > > > Please, let me known if I should do this as a separate patch > > and/or resend the patchset. > Rui/Eduardo, > There are four independent posted changes made

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon, 2016-11-14 at 11:12 -0800, Jacob Pan wrote: > On Fri, 11 Nov 2016 18:34:10 +0100 > Petr Mladek wrote: > > > > > Please, let me known if I should do this as a separate patch > > and/or resend the patchset. > Rui/Eduardo, > There are four independent posted changes made to powerclamp

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri, 11 Nov 2016 18:34:10 +0100 Petr Mladek wrote: > Please, let me known if I should do this as a separate patch > and/or resend the patchset. Rui/Eduardo, There are four independent posted changes made to powerclamp driver: Should I roll them into one set such that you

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri, 11 Nov 2016 18:34:10 +0100 Petr Mladek wrote: > Please, let me known if I should do this as a separate patch > and/or resend the patchset. Rui/Eduardo, There are four independent posted changes made to powerclamp driver: Should I roll them into one set such that you can easily apply

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri 2016-11-11 11:07:13, Petr Mladek wrote: > I am going to do some more tests and will send a fix. It should > be enough to remove the KTW_FREEZABLE flag from the > kthread_create_worker_on_cpu() call. Please, find below an updated patch that fixes the suspend with kidle_inject kthreads

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri 2016-11-11 11:07:13, Petr Mladek wrote: > I am going to do some more tests and will send a fix. It should > be enough to remove the KTW_FREEZABLE flag from the > kthread_create_worker_on_cpu() call. Please, find below an updated patch that fixes the suspend with kidle_inject kthreads

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri 2016-11-11 10:33:30, Petr Mladek wrote: > Then I tried to revert the conversion to the kthread worker > API (2nd patch from this patchset), see below. And it still > hangs during the suspend inside > > powerclamp_cpu_predown() > kthread_stop(*percpu_thread); > > > Note that

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri 2016-11-11 10:33:30, Petr Mladek wrote: > Then I tried to revert the conversion to the kthread worker > API (2nd patch from this patchset), see below. And it still > hangs during the suspend inside > > powerclamp_cpu_predown() > kthread_stop(*percpu_thread); > > > Note that

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Thu 2016-10-27 13:27:36, Jacob Pan wrote: > On Thu, 27 Oct 2016 17:17:26 +0200 > Sebastian Andrzej Siewior wrote: > > > On 2016-10-27 16:53:48 [+0200], Petr Mladek wrote: > > > > > > In each case, I wonder if the problem is caused by the conversion > > > to the kthread

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Thu 2016-10-27 13:27:36, Jacob Pan wrote: > On Thu, 27 Oct 2016 17:17:26 +0200 > Sebastian Andrzej Siewior wrote: > > > On 2016-10-27 16:53:48 [+0200], Petr Mladek wrote: > > > > > > In each case, I wonder if the problem is caused by the conversion > > > to the kthread worker or by the CPU

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Thu, 27 Oct 2016 17:17:26 +0200 Sebastian Andrzej Siewior wrote: > On 2016-10-27 16:53:48 [+0200], Petr Mladek wrote: > > > > In each case, I wonder if the problem is caused by the conversion > > to the kthread worker or by the CPU hotplug state conversion. > > drop

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Thu, 27 Oct 2016 17:17:26 +0200 Sebastian Andrzej Siewior wrote: > On 2016-10-27 16:53:48 [+0200], Petr Mladek wrote: > > > > In each case, I wonder if the problem is caused by the conversion > > to the kthread worker or by the CPU hotplug state conversion. > > drop the hotplug patch and

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On 2016-10-27 16:53:48 [+0200], Petr Mladek wrote: > > In each case, I wonder if the problem is caused by the conversion > to the kthread worker or by the CPU hotplug state conversion. drop the hotplug patch and you will see. > Best Regards, > Petr Sebastian

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On 2016-10-27 16:53:48 [+0200], Petr Mladek wrote: > > In each case, I wonder if the problem is caused by the conversion > to the kthread worker or by the CPU hotplug state conversion. drop the hotplug patch and you will see. > Best Regards, > Petr Sebastian

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon 2016-10-24 09:55:29, Jacob Pan wrote: > On Mon, 24 Oct 2016 17:48:07 +0200 > Petr Mladek wrote: > > > On Fri 2016-10-21 13:21:18, Jacob Pan wrote: > > > On Mon, 17 Oct 2016 14:32:52 +0200 > > > Petr Mladek wrote: > > > > > > > From: Sebastian Andrzej

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon 2016-10-24 09:55:29, Jacob Pan wrote: > On Mon, 24 Oct 2016 17:48:07 +0200 > Petr Mladek wrote: > > > On Fri 2016-10-21 13:21:18, Jacob Pan wrote: > > > On Mon, 17 Oct 2016 14:32:52 +0200 > > > Petr Mladek wrote: > > > > > > > From: Sebastian Andrzej Siewior > > > > > > > Hi

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon, 24 Oct 2016 17:48:07 +0200 Petr Mladek wrote: > On Fri 2016-10-21 13:21:18, Jacob Pan wrote: > > On Mon, 17 Oct 2016 14:32:52 +0200 > > Petr Mladek wrote: > > > > > From: Sebastian Andrzej Siewior > > > > > Hi Sebastian, > >

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon, 24 Oct 2016 17:48:07 +0200 Petr Mladek wrote: > On Fri 2016-10-21 13:21:18, Jacob Pan wrote: > > On Mon, 17 Oct 2016 14:32:52 +0200 > > Petr Mladek wrote: > > > > > From: Sebastian Andrzej Siewior > > > > > Hi Sebastian, > > I applied this patchset on 4.9-rc1 and run some cpu

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri 2016-10-21 13:21:18, Jacob Pan wrote: > On Mon, 17 Oct 2016 14:32:52 +0200 > Petr Mladek wrote: > > > From: Sebastian Andrzej Siewior > > > Hi Sebastian, > I applied this patchset on 4.9-rc1 and run some cpu online/offline > loops test while

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Fri 2016-10-21 13:21:18, Jacob Pan wrote: > On Mon, 17 Oct 2016 14:32:52 +0200 > Petr Mladek wrote: > > > From: Sebastian Andrzej Siewior > > > Hi Sebastian, > I applied this patchset on 4.9-rc1 and run some cpu online/offline > loops test while injecting idle, e.g. 25%. I got system hang

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon, 17 Oct 2016 14:32:52 +0200 Petr Mladek wrote: > From: Sebastian Andrzej Siewior > Hi Sebastian, I applied this patchset on 4.9-rc1 and run some cpu online/offline loops test while injecting idle, e.g. 25%. I got system hang after a few cycles.

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

On Mon, 17 Oct 2016 14:32:52 +0200 Petr Mladek wrote: > From: Sebastian Andrzej Siewior > Hi Sebastian, I applied this patchset on 4.9-rc1 and run some cpu online/offline loops test while injecting idle, e.g. 25%. I got system hang after a few cycles. Still looking into root cause. Thanks,

[PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

From: Sebastian Andrzej Siewior This is a conversation to the new hotplug state machine with the difference that CPU_DEAD becomes CPU_PREDOWN. At the same time it makes the handling of the two states symmetrical. stop_power_clamp_worker() is called unconditionally and the

[PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

From: Sebastian Andrzej Siewior This is a conversation to the new hotplug state machine with the difference that CPU_DEAD becomes CPU_PREDOWN. At the same time it makes the handling of the two states symmetrical. stop_power_clamp_worker() is called unconditionally and the controversial error