Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-17 Thread Henrique de Moraes Holschuh
On Fri, 07 Jun 2013, Adam Lee wrote: > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. > This patch adds their quirks. > > Signed-off-by: Adam Lee NAK. Let's see if we can do this in a better way that is a bit more future-proof. -- "One disk to rule them all, One disk t

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-08 Thread Adam Lee
e apply "[PATCH 1/3 v3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs" and "[PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk", but hold "[PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllabl

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Henrique de Moraes Holschuh
Can you get me the ACPI interface documentation? It should be simple to get it, but I haven't emailed the Lenovo BIOS engineers for some time. Basically, create a new LED method in thinkpad-acpi, lock it down to vendor lenovo, detect the new interfaces, and only check the two-argument LED one i

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Adam Lee
On Fri, Jun 07, 2013 at 01:22:39PM +, Matthew Garrett wrote: > On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote: > > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. > > This patch adds their quirks. > > Can you detect this case? If this is a new way of doing things then >

Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Matthew Garrett
On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote: > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. > This patch adds their quirks. Can you detect this case? If this is a new way of doing things then you're going to have to add new entries to the quirk list every time Lenovo

[PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-07 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. This patch adds their quirks. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_a