Re: [PATCH 3/3] tracing: Add support for dynamic strings to synthetic events

2020-09-29 Thread Steven Rostedt
On Tue, 29 Sep 2020 15:01:59 -0700 Axel Rasmussen wrote: > > event->fields[i]->offset = n_u64; > > > > - if (event->fields[i]->is_string) { > > + if (event->fields[i]->is_string && > > !event->fields[i]->is_dynamic) { > > offset

Re: [PATCH 3/3] tracing: Add support for dynamic strings to synthetic events

2020-09-29 Thread Axel Rasmussen
On Tue, Sep 29, 2020 at 1:33 PM Tom Zanussi wrote: > > Currently, sythetic events only support static string fields such as: > > # echo 'test_latency u64 lat; char somename[32]' > > /sys/kernel/debug/tracing/synthetic_events > > Which is fine, but wastes a lot of space in the event. > > It also

[PATCH 3/3] tracing: Add support for dynamic strings to synthetic events

2020-09-29 Thread Tom Zanussi
Currently, sythetic events only support static string fields such as: # echo 'test_latency u64 lat; char somename[32]' > /sys/kernel/debug/tracing/synthetic_events Which is fine, but wastes a lot of space in the event. It also prevents the most commonly-defined strings in the existing trace e