Re: [PATCH 3/3] tracing: Verify target file before registering a uprobe event

2013-01-07 Thread Steven Rostedt
Jovi, As Namhyung pointed out. Can you fix the below and resend. On Wed, 2013-01-02 at 17:50 -0500, Steven Rostedt wrote: > From: Jovi Zhang > > Without this patch, we can register a uprobe event for a directory. > Enabling such a uprobe event would fail anyway . > > Example: > $ echo 'p /bin

Re: [PATCH 3/3] tracing: Verify target file before registering a uprobe event

2013-01-07 Thread Steven Rostedt
On Fri, 2013-01-04 at 13:30 +0900, Namhyung Kim wrote: > Hi, Steve. > > On Wed, 02 Jan 2013 17:50:38 -0500, Steven Rostedt wrote: > > From: Jovi Zhang > > > > Without this patch, we can register a uprobe event for a directory. > > Enabling such a uprobe event would fail anyway . > > > > Example:

Re: [PATCH 3/3] tracing: Verify target file before registering a uprobe event

2013-01-03 Thread Namhyung Kim
Hi, Steve. On Wed, 02 Jan 2013 17:50:38 -0500, Steven Rostedt wrote: > From: Jovi Zhang > > Without this patch, we can register a uprobe event for a directory. > Enabling such a uprobe event would fail anyway . > > Example: > $ echo 'p /bin:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events > >

[PATCH 3/3] tracing: Verify target file before registering a uprobe event

2013-01-02 Thread Steven Rostedt
From: Jovi Zhang Without this patch, we can register a uprobe event for a directory. Enabling such a uprobe event would fail anyway . Example: $ echo 'p /bin:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events However dirctories cannot be valid targets for uprobe. Hence verify if the target is