Re: [PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size

2014-03-03 Thread Steven Rostedt
On Mon, 3 Mar 2014 15:48:26 -0500 Steven Rostedt wrote: > without patch: > > pst2pdf-3506 [000] 120.700910: sched_process_exec: > filename=/usr/bin/pst2pdf pid=3506 old_pid=3506 > > > With patch: > > pstopnm-4432 [001] 1490.246765: sched_process_exec: filename= >

Re: [PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size

2014-03-03 Thread Steven Rostedt
You're right, this one will bring up discussion. On Fri, 28 Feb 2014 21:32:18 -0800 Filipe Brandenburger wrote: > Commit 7d536cb3f stores the length of the array in the high 16 bits of > the offset field. Using a struct with two separate 16 bit fields makes > it cleaner. > > Tested: Boot

Re: [PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size

2014-03-03 Thread Steven Rostedt
You're right, this one will bring up discussion. On Fri, 28 Feb 2014 21:32:18 -0800 Filipe Brandenburger filbran...@google.com wrote: Commit 7d536cb3f stores the length of the array in the high 16 bits of the offset field. Using a struct with two separate 16 bit fields makes it cleaner.

Re: [PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size

2014-03-03 Thread Steven Rostedt
On Mon, 3 Mar 2014 15:48:26 -0500 Steven Rostedt rost...@goodmis.org wrote: without patch: pst2pdf-3506 [000] 120.700910: sched_process_exec: filename=/usr/bin/pst2pdf pid=3506 old_pid=3506 With patch: pstopnm-4432 [001] 1490.246765: sched_process_exec:

[PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size

2014-02-28 Thread Filipe Brandenburger
Commit 7d536cb3f stores the length of the array in the high 16 bits of the offset field. Using a struct with two separate 16 bit fields makes it cleaner. Tested: Boot kernel with this change, set a 'filename ~ "/usr/bin/pst*"' regex filter on events/sched/sched_process_exec/filter, enabled

[PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size

2014-02-28 Thread Filipe Brandenburger
Commit 7d536cb3f stores the length of the array in the high 16 bits of the offset field. Using a struct with two separate 16 bit fields makes it cleaner. Tested: Boot kernel with this change, set a 'filename ~ /usr/bin/pst*' regex filter on events/sched/sched_process_exec/filter, enabled tracing,