Re: [PATCH 3/3] uprobes/x86: Simplify riprel_{pre,post}_xol() and make them similar

2014-04-30 Thread Jim Keniston
On Mon, 2014-04-28 at 12:06 +0530, Srikar Dronamraju wrote: > * Oleg Nesterov [2014-04-27 18:52:30]: > > > Ignoring the "correction" logic riprel_pre_xol() and riprel_post_xol() > > are very similar but look quite differently. > > > > 1. Add the "UPROBE_FIX_RIP_AX | UPROBE_FIX_RIP_CX" check at t

Re: [PATCH 3/3] uprobes/x86: Simplify riprel_{pre,post}_xol() and make them similar

2014-04-27 Thread Srikar Dronamraju
* Oleg Nesterov [2014-04-27 18:52:30]: > Ignoring the "correction" logic riprel_pre_xol() and riprel_post_xol() > are very similar but look quite differently. > > 1. Add the "UPROBE_FIX_RIP_AX | UPROBE_FIX_RIP_CX" check at the start >of riprel_pre_xol(), like the same check in riprel_post_xo

[PATCH 3/3] uprobes/x86: Simplify riprel_{pre,post}_xol() and make them similar

2014-04-27 Thread Oleg Nesterov
Ignoring the "correction" logic riprel_pre_xol() and riprel_post_xol() are very similar but look quite differently. 1. Add the "UPROBE_FIX_RIP_AX | UPROBE_FIX_RIP_CX" check at the start of riprel_pre_xol(), like the same check in riprel_post_xol(). 2. Add the trivial scratch_reg() helper which