Re: [PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Imre Deak
On Fri, 2014-12-12 at 17:45 -0500, Peter Hurley wrote: > [ +cc Daniel because of the i915 lockdep report ] > > On 12/12/2014 05:03 PM, Imre Deak wrote: > > On Fri, 2014-12-12 at 16:03 -0500, Peter Hurley wrote: > >> On 12/12/2014 03:29 PM, Imre Deak wrote: > >>> Hi Peter, > >>> > >>> thanks for yo

Re: [PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Peter Hurley
[ +cc Daniel because of the i915 lockdep report ] On 12/12/2014 05:03 PM, Imre Deak wrote: > On Fri, 2014-12-12 at 16:03 -0500, Peter Hurley wrote: >> On 12/12/2014 03:29 PM, Imre Deak wrote: >>> Hi Peter, >>> >>> thanks for your review. >>> >>> On Fri, 2014-12-12 at 13:32 -0500, Peter Hurley wrot

Re: [PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Imre Deak
On Fri, 2014-12-12 at 16:03 -0500, Peter Hurley wrote: > On 12/12/2014 03:29 PM, Imre Deak wrote: > > Hi Peter, > > > > thanks for your review. > > > > On Fri, 2014-12-12 at 13:32 -0500, Peter Hurley wrote: > >> Hi Imre, > >> > >> On 12/12/2014 11:38 AM, Imre Deak wrote: > >>> Currently there is

Re: [PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Peter Hurley
On 12/12/2014 03:29 PM, Imre Deak wrote: > Hi Peter, > > thanks for your review. > > On Fri, 2014-12-12 at 13:32 -0500, Peter Hurley wrote: >> Hi Imre, >> >> On 12/12/2014 11:38 AM, Imre Deak wrote: >>> Currently there is a lock order problem between the console lock and the >>> kernfs s_active l

Re: [PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Imre Deak
On Fri, 2014-12-12 at 22:29 +0200, Imre Deak wrote: > Hi Peter, > > thanks for your review. > > On Fri, 2014-12-12 at 13:32 -0500, Peter Hurley wrote: > > Hi Imre, > > > > On 12/12/2014 11:38 AM, Imre Deak wrote: > > > Currently there is a lock order problem between the console lock and the > >

Re: [PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Imre Deak
Hi Peter, thanks for your review. On Fri, 2014-12-12 at 13:32 -0500, Peter Hurley wrote: > Hi Imre, > > On 12/12/2014 11:38 AM, Imre Deak wrote: > > Currently there is a lock order problem between the console lock and the > > kernfs s_active lock of the console driver's bind sysfs entry. When >

Re: [PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Peter Hurley
Hi Imre, On 12/12/2014 11:38 AM, Imre Deak wrote: > Currently there is a lock order problem between the console lock and the > kernfs s_active lock of the console driver's bind sysfs entry. When > writing to the sysfs entry the lock order is first s_active then console > lock, when unregistering t

[PATCH 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-12 Thread Imre Deak
Currently there is a lock order problem between the console lock and the kernfs s_active lock of the console driver's bind sysfs entry. When writing to the sysfs entry the lock order is first s_active then console lock, when unregistering the console driver via do_unregister_con_driver() the order