Re: [PATCH 3/3] watchdog: sprd: check busy bit before kick watchdog

2020-10-27 Thread Chunyan Zhang
On Mon, 26 Oct 2020 at 22:44, Guenter Roeck wrote: > > On 10/26/20 1:09 AM, Chunyan Zhang wrote: > > From: Lingling Xu > > > > As the specification described, checking busy bit must be done before kick > > watchdog. > > > > That is a key functional change: So far the code checked if a value > was

Re: [PATCH 3/3] watchdog: sprd: check busy bit before kick watchdog

2020-10-26 Thread Guenter Roeck
On 10/26/20 1:09 AM, Chunyan Zhang wrote: > From: Lingling Xu > > As the specification described, checking busy bit must be done before kick > watchdog. > That is a key functional change: So far the code checked if a value was accepted after loading it. That is no longer the case. Effectively,

[PATCH 3/3] watchdog: sprd: check busy bit before kick watchdog

2020-10-26 Thread Chunyan Zhang
From: Lingling Xu As the specification described, checking busy bit must be done before kick watchdog. Fixes: 477603467009 ("watchdog: Add Spreadtrum watchdog driver") Signed-off-by: Lingling Xu Signed-off-by: Chunyan Zhang --- drivers/watchdog/sprd_wdt.c | 27 ++- 1 f