Re: [PATCH 3/3] workqueue: remove unused argument of wq_worker_waking_up()

2012-10-24 Thread Tejun Heo
On Tue, Oct 23, 2012 at 10:44:49AM +0900, JoonSoo Kim wrote: > > if (!(worker->flags & WORKER_NOT_RUNNING)) { > > WARN_ON_ONCE(worker->pool->gcwq->cpu != cpu); > > atomic_inc(get_pool_nr_running(worker->pool)); > > } > > > > I have no objection to do

Re: [PATCH 3/3] workqueue: remove unused argument of wq_worker_waking_up()

2012-10-22 Thread JoonSoo Kim
2012/10/21 Tejun Heo : > On Sun, Oct 21, 2012 at 01:30:07AM +0900, Joonsoo Kim wrote: >> Commit 63d95a91 ('workqueue: use @pool instead of @gcwq or @cpu where >> applicable') changes an approach to access nr_running. >> Thus, wq_worker_waking_up() doesn't use @cpu anymore. >> Remove it and remove c

Re: [PATCH 3/3] workqueue: remove unused argument of wq_worker_waking_up()

2012-10-20 Thread Tejun Heo
On Sun, Oct 21, 2012 at 01:30:07AM +0900, Joonsoo Kim wrote: > Commit 63d95a91 ('workqueue: use @pool instead of @gcwq or @cpu where > applicable') changes an approach to access nr_running. > Thus, wq_worker_waking_up() doesn't use @cpu anymore. > Remove it and remove comment related to it. > > Si

[PATCH 3/3] workqueue: remove unused argument of wq_worker_waking_up()

2012-10-20 Thread Joonsoo Kim
Commit 63d95a91 ('workqueue: use @pool instead of @gcwq or @cpu where applicable') changes an approach to access nr_running. Thus, wq_worker_waking_up() doesn't use @cpu anymore. Remove it and remove comment related to it. Signed-off-by: Joonsoo Kim diff --git a/kernel/sched/core.c b/kernel/sche