Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

Hi Jan, On Thursday 03 May 2007 17:41, Jan Kratochvil wrote: > Hi again, >what do you think about this? (This patch will work only against last > gamepad rumble support patch) > > Thanks for your time > Jan Kratochvil > > BigX button on xbox360 gamepad is surrounded by 4 green leds.

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

On Thursday 03 May 2007 09:04, Jan Kratochvil wrote: > Hi Dmitry, >thanks for feedback. Improved version of this patch follows: > > It is enabled only if CONFIG_XPAD_FF is set to y. > > Implementation is using force feedback support for memoryless devices. Applied with couple cosmetic

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

On Thursday 03 May 2007 09:04, Jan Kratochvil wrote: Hi Dmitry, thanks for feedback. Improved version of this patch follows: It is enabled only if CONFIG_XPAD_FF is set to y. Implementation is using force feedback support for memoryless devices. Applied with couple cosmetic changes,

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

Hi Jan, On Thursday 03 May 2007 17:41, Jan Kratochvil wrote: Hi again, what do you think about this? (This patch will work only against last gamepad rumble support patch) Thanks for your time Jan Kratochvil BigX button on xbox360 gamepad is surrounded by 4 green leds. This

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

Hi again, what do you think about this? (This patch will work only against last gamepad rumble support patch) Thanks for your time Jan Kratochvil BigX button on xbox360 gamepad is surrounded by 4 green leds. This patch adds support to control them. This device understand to 14

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

Hi Dmitry, thanks for feedback. Improved version of this patch follows: It is enabled only if CONFIG_XPAD_FF is set to y. Implementation is using force feedback support for memoryless devices. Signed-off-by: Jan Kratochvil <[EMAIL PROTECTED]> --- drivers/usb/input/Kconfig |7 +++

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

Hi Dmitry, thanks for feedback. Improved version of this patch follows: It is enabled only if CONFIG_XPAD_FF is set to y. Implementation is using force feedback support for memoryless devices. Signed-off-by: Jan Kratochvil [EMAIL PROTECTED] --- drivers/usb/input/Kconfig |7 +++

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

Hi again, what do you think about this? (This patch will work only against last gamepad rumble support patch) Thanks for your time Jan Kratochvil BigX button on xbox360 gamepad is surrounded by 4 green leds. This patch adds support to control them. This device understand to 14

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

On Wednesday 02 May 2007 11:05, Jan Kratochvil wrote: > > +config XPAD_FF > + default n Please don't default to anything. > > +#ifdef CONFIG_XPAD_FF > +/** > + * xpad_irq_out > + */ Comments are welcome when they say something... > +static void xpad_irq_out(struct urb *urb) > +{

[PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

It is enabled only if CONFIG_XPAD_FF is set to y. Implementation is using force feedback support for memoryless devices. Signed-off-by: Jan Kratochvil <[EMAIL PROTECTED]> --- drivers/usb/input/Kconfig |8 +++ drivers/usb/input/xpad.c | 116 + 2

[PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

It is enabled only if CONFIG_XPAD_FF is set to y. Implementation is using force feedback support for memoryless devices. Signed-off-by: Jan Kratochvil [EMAIL PROTECTED] --- drivers/usb/input/Kconfig |8 +++ drivers/usb/input/xpad.c | 116 + 2

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

On Wednesday 02 May 2007 11:05, Jan Kratochvil wrote: +config XPAD_FF + default n Please don't default to anything. +#ifdef CONFIG_XPAD_FF +/** + * xpad_irq_out + */ Comments are welcome when they say something... +static void xpad_irq_out(struct urb *urb) +{ +