Am 16.12.2012 23:15, schrieb Alessandro Zummo:
On Tue, 11 Dec 2012 10:40:01 +0100
Lars-Peter Clausen wrote:
Yes, move the header or merge into existing one as makes sense.
I'm not pulling this driver into the IIO tree (unless for some
reason Alessandro wants me to and I can't think why he
On Tue, 11 Dec 2012 10:40:01 +0100
Lars-Peter Clausen wrote:
> > Yes, move the header or merge into existing one as makes sense.
> > I'm not pulling this driver into the IIO tree (unless for some
> > reason Alessandro wants me to and I can't think why he would...).
> >
>
> Alessandro has
On Tue, 11 Dec 2012 10:40:01 +0100
Lars-Peter Clausen l...@metafoo.de wrote:
Yes, move the header or merge into existing one as makes sense.
I'm not pulling this driver into the IIO tree (unless for some
reason Alessandro wants me to and I can't think why he would...).
Alessandro
Am 16.12.2012 23:15, schrieb Alessandro Zummo:
On Tue, 11 Dec 2012 10:40:01 +0100
Lars-Peter Clausen l...@metafoo.de wrote:
Yes, move the header or merge into existing one as makes sense.
I'm not pulling this driver into the IIO tree (unless for some
reason Alessandro wants me to and I can't
On 11/12/12 12:39, Alexander Holler wrote:
Am 11.12.2012 10:40, schrieb Lars-Peter Clausen:
Yes, move the header or merge into existing one as makes sense.
I'm not pulling this driver into the IIO tree (unless for some
reason Alessandro wants me to and I can't think why he would...).
Am 11.12.2012 10:40, schrieb Lars-Peter Clausen:
Yes, move the header or merge into existing one as makes sense.
I'm not pulling this driver into the IIO tree (unless for some
reason Alessandro wants me to and I can't think why he would...).
Alessandro has been pretty quiet for quite some
On Tue, 11 Dec 2012 01:01:29 +0100
Alexander Holler wrote:
> Am 10.12.2012 23:36, schrieb Lars-Peter Clausen:
> > Well, I've been exaggerating a bit, you can call it multiple times, but you
>
> Thanks a lot for the explanation(s).
>
> +error_free_drvdata:
> +
On 12/11/2012 10:31 AM, Jonathan Cameron wrote:
> On 10/12/12 22:50, Alexander Holler wrote:
>> Am 10.12.2012 22:42, schrieb Jonathan Cameron:
>>> On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
On 12/10/2012 10:26 PM, Alexander Holler wrote:
> Am 10.12.2012 21:22, schrieb Lars-Peter
On 10/12/12 22:50, Alexander Holler wrote:
Am 10.12.2012 22:42, schrieb Jonathan Cameron:
On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
On 12/10/2012 10:26 PM, Alexander Holler wrote:
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am
On 10/12/12 22:50, Alexander Holler wrote:
Am 10.12.2012 22:42, schrieb Jonathan Cameron:
On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
On 12/10/2012 10:26 PM, Alexander Holler wrote:
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am
On 12/11/2012 10:31 AM, Jonathan Cameron wrote:
On 10/12/12 22:50, Alexander Holler wrote:
Am 10.12.2012 22:42, schrieb Jonathan Cameron:
On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
On 12/10/2012 10:26 PM, Alexander Holler wrote:
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On
On Tue, 11 Dec 2012 01:01:29 +0100
Alexander Holler hol...@ahsoftware.de wrote:
Am 10.12.2012 23:36, schrieb Lars-Peter Clausen:
Well, I've been exaggerating a bit, you can call it multiple times, but you
Thanks a lot for the explanation(s).
+error_free_drvdata:
+
Am 11.12.2012 10:40, schrieb Lars-Peter Clausen:
Yes, move the header or merge into existing one as makes sense.
I'm not pulling this driver into the IIO tree (unless for some
reason Alessandro wants me to and I can't think why he would...).
Alessandro has been pretty quiet for quite some
On 11/12/12 12:39, Alexander Holler wrote:
Am 11.12.2012 10:40, schrieb Lars-Peter Clausen:
Yes, move the header or merge into existing one as makes sense.
I'm not pulling this driver into the IIO tree (unless for some
reason Alessandro wants me to and I can't think why he would...).
Am 10.12.2012 23:36, schrieb Lars-Peter Clausen:
Well, I've been exaggerating a bit, you can call it multiple times, but you
Thanks a lot for the explanation(s).
+error_free_drvdata:
+platform_set_drvdata(pdev, NULL);
Setting the platform data to NULL should not be necessary. Some
Am 10.12.2012 22:42, schrieb Jonathan Cameron:
On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
On 12/10/2012 10:26 PM, Alexander Holler wrote:
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
On 12/10/2012 11:20 PM, Alexander Holler wrote:
> [...]
>>> +init_completion(_state->comp_last_time);
>>
>> This needs to be INIT_COMPLETION. init_completion must be called exactly
>> once on a completion, which should be from inside probe() in this case.
>
> Ah, so I've misread
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
On 12/10/2012 03:51 PM, Alexander Holler wrote:
The channel spec is semi unused. You use it to lookup the scan index and the
name, but that could easily be implemented without the channel spec.
Especially considering that the scan index lookup
On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
> On 12/10/2012 10:26 PM, Alexander Holler wrote:
>> Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
>>> On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
> Looks pretty good now. But
On 12/10/2012 10:26 PM, Alexander Holler wrote:
> Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
>> On 12/10/2012 08:45 PM, Alexander Holler wrote:
>>> Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
>>>
Looks pretty good now. But there are still some IIO remnants which should
be
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
> On 12/10/2012 08:45 PM, Alexander Holler wrote:
>> Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
>>
>>> Looks pretty good now. But there are still some IIO remnants which should be
>>> removed as well. Also the driver should move to
On 12/10/2012 08:45 PM, Alexander Holler wrote:
> Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
>
>> Looks pretty good now. But there are still some IIO remnants which should be
>> removed as well. Also the driver should move to drivers/rtc/ since, well,
>> it's a rtc driver not a IIO driver.
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
> Looks pretty good now. But there are still some IIO remnants which should be
> removed as well. Also the driver should move to drivers/rtc/ since, well,
> it's a rtc driver not a IIO driver.
I think it still should be stick to iio, because that
On 12/10/2012 03:51 PM, Alexander Holler wrote:
> This driver makes the time from HID sensors (hubs) which are offering
> such available like any other RTC does.
>
> Currently the time can only be read. Setting the time must be done
> through sending a report, which currently isn't supported by
>
This driver makes the time from HID sensors (hubs) which are offering
such available like any other RTC does.
Currently the time can only be read. Setting the time must be done
through sending a report, which currently isn't supported by
hid-sensor-hub.
It is necessary that all values like year,
This driver makes the time from HID sensors (hubs) which are offering
such available like any other RTC does.
Currently the time can only be read. Setting the time must be done
through sending a report, which currently isn't supported by
hid-sensor-hub.
It is necessary that all values like year,
On 12/10/2012 03:51 PM, Alexander Holler wrote:
This driver makes the time from HID sensors (hubs) which are offering
such available like any other RTC does.
Currently the time can only be read. Setting the time must be done
through sending a report, which currently isn't supported by
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
Looks pretty good now. But there are still some IIO remnants which should be
removed as well. Also the driver should move to drivers/rtc/ since, well,
it's a rtc driver not a IIO driver.
I think it still should be stick to iio, because that is
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
Looks pretty good now. But there are still some IIO remnants which should be
removed as well. Also the driver should move to drivers/rtc/ since, well,
it's a rtc driver not a IIO driver.
I
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
Looks pretty good now. But there are still some IIO remnants which should be
removed as well. Also the driver should move to drivers/rtc/ since,
On 12/10/2012 10:26 PM, Alexander Holler wrote:
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
Looks pretty good now. But there are still some IIO remnants which should
be
removed as well.
On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
On 12/10/2012 10:26 PM, Alexander Holler wrote:
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
Looks pretty good now. But there are still some
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
On 12/10/2012 03:51 PM, Alexander Holler wrote:
The channel spec is semi unused. You use it to lookup the scan index and the
name, but that could easily be implemented without the channel spec.
Especially considering that the scan index lookup
On 12/10/2012 11:20 PM, Alexander Holler wrote:
[...]
+init_completion(time_state-comp_last_time);
This needs to be INIT_COMPLETION. init_completion must be called exactly
once on a completion, which should be from inside probe() in this case.
Ah, so I've misread
Am 10.12.2012 22:42, schrieb Jonathan Cameron:
On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
On 12/10/2012 10:26 PM, Alexander Holler wrote:
Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
On 12/10/2012 08:45 PM, Alexander Holler wrote:
Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
Am 10.12.2012 23:36, schrieb Lars-Peter Clausen:
Well, I've been exaggerating a bit, you can call it multiple times, but you
Thanks a lot for the explanation(s).
+error_free_drvdata:
+platform_set_drvdata(pdev, NULL);
Setting the platform data to NULL should not be necessary. Some
36 matches
Mail list logo
