Re: [PATCH 3/3 v2] net/macb: Try to optimize struct macb layout

2012-12-17 Thread Ben Hutchings
On Mon, 2012-12-17 at 14:01 +0100, Nicolas Ferre wrote: > From: Havard Skinnemoen > > Move TX-related fields to the top of the struct so that they end up on > the same cache line. Move the NAPI struct below that since it is used > from the interrupt handler. RX-related fields go below those. >

[PATCH 3/3 v2] net/macb: Try to optimize struct macb layout

2012-12-17 Thread Nicolas Ferre
From: Havard Skinnemoen Move TX-related fields to the top of the struct so that they end up on the same cache line. Move the NAPI struct below that since it is used from the interrupt handler. RX-related fields go below those. Move the spinlock before regs since they are usually used together.

[PATCH 3/3 v2] net/macb: Try to optimize struct macb layout

2012-12-17 Thread Nicolas Ferre
From: Havard Skinnemoen hav...@skinnemoen.net Move TX-related fields to the top of the struct so that they end up on the same cache line. Move the NAPI struct below that since it is used from the interrupt handler. RX-related fields go below those. Move the spinlock before regs since they are

Re: [PATCH 3/3 v2] net/macb: Try to optimize struct macb layout

2012-12-17 Thread Ben Hutchings
On Mon, 2012-12-17 at 14:01 +0100, Nicolas Ferre wrote: From: Havard Skinnemoen hav...@skinnemoen.net Move TX-related fields to the top of the struct so that they end up on the same cache line. Move the NAPI struct below that since it is used from the interrupt handler. RX-related fields go