Re: [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization

2020-10-23 Thread kernel test robot
Hi Kai-Heng, Thank you for the patch! Yet something to improve: [auto build test ERROR on sound/for-next] [also build test ERROR on v5.9 next-20201023] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

Re: [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization

2020-10-23 Thread Kai-Heng Feng
> On Oct 23, 2020, at 19:36, Takashi Iwai wrote: > > On Fri, 23 Oct 2020 12:23:37 +0200, > Kai-Heng Feng wrote: >> @@ -1103,10 +1096,8 @@ static int azx_runtime_suspend(struct device *dev) >> chip = card->private_data; >> >> /* enable controller wake up event */ >> -if

Re: [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization

2020-10-23 Thread Takashi Iwai
On Fri, 23 Oct 2020 12:23:37 +0200, Kai-Heng Feng wrote: > @@ -1103,10 +1096,8 @@ static int azx_runtime_suspend(struct device *dev) > chip = card->private_data; > > /* enable controller wake up event */ > - if (snd_power_get_state(card) == SNDRV_CTL_POWER_D0) { > -

[PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization

2020-10-23 Thread Kai-Heng Feng
Similar to codec, we can use direct-complete optimization to keep HDA controller suspended if conditions are met. For most integrated HDA controllers, direct-complete won't happen because ACPI wakeup is enabled for runtime suspend, but wakeup needs to be disabled for system suspend. For most HDA