Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On 22/08/2016 23:17, SF Markus Elfring wrote: >> If in doubt, the compiler will be _much_ better at optimizing >> that kind of stuff anyway. > > Which compiler (or optimizer) implementation is capable to restructure > the jump targets for you automatically in the way I propose here? If kfree

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On 22/08/2016 23:17, SF Markus Elfring wrote: >> If in doubt, the compiler will be _much_ better at optimizing >> that kind of stuff anyway. > > Which compiler (or optimizer) implementation is capable to restructure > the jump targets for you automatically in the way I propose here? If kfree

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On 08/17/2016 02:10 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 Aug 2016 19:25:50 +0200 > > The kfree() function was called in a few cases by the > kvm_s390_import_bp_data() function during error handling > even if a passed variable

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On 08/17/2016 02:10 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 Aug 2016 19:25:50 +0200 > > The kfree() function was called in a few cases by the > kvm_s390_import_bp_data() function during error handling > even if a passed variable contained a null pointer. > > Adjust

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On Mon, 22 Aug 2016 23:17:26 +0200 SF Markus Elfring wrote: > @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, > vcpu->arch.guestdbg.nr_hw_wp = nr_wp; > vcpu->arch.guestdbg.hw_wp_info = wp_info; >

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On Mon, 22 Aug 2016 23:17:26 +0200 SF Markus Elfring wrote: > @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, > vcpu->arch.guestdbg.nr_hw_wp = nr_wp; > vcpu->arch.guestdbg.hw_wp_info = wp_info; > return 0; > -error: >

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

@@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, vcpu->arch.guestdbg.nr_hw_wp = nr_wp; vcpu->arch.guestdbg.hw_wp_info = wp_info; return 0; -error: - kfree(bp_data); - kfree(wp_info); +free_bp_info: kfree(bp_info);

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

@@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, vcpu->arch.guestdbg.nr_hw_wp = nr_wp; vcpu->arch.guestdbg.hw_wp_info = wp_info; return 0; -error: - kfree(bp_data); - kfree(wp_info); +free_bp_info: kfree(bp_info);

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On Mon, 22 Aug 2016 18:56:47 +0200 SF Markus Elfring wrote: > >> @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, > >>vcpu->arch.guestdbg.nr_hw_wp = nr_wp; > >>vcpu->arch.guestdbg.hw_wp_info = wp_info; > >>return 0; > >> -error:

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On Mon, 22 Aug 2016 18:56:47 +0200 SF Markus Elfring wrote: > >> @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, > >>vcpu->arch.guestdbg.nr_hw_wp = nr_wp; > >>vcpu->arch.guestdbg.hw_wp_info = wp_info; > >>return 0; > >> -error: > >> - kfree(bp_data); > >> -

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

>> @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, >> vcpu->arch.guestdbg.nr_hw_wp = nr_wp; >> vcpu->arch.guestdbg.hw_wp_info = wp_info; >> return 0; >> -error: >> -kfree(bp_data); >> -kfree(wp_info); >> +free_bp_info: >> kfree(bp_info); >>

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

>> @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, >> vcpu->arch.guestdbg.nr_hw_wp = nr_wp; >> vcpu->arch.guestdbg.hw_wp_info = wp_info; >> return 0; >> -error: >> -kfree(bp_data); >> -kfree(wp_info); >> +free_bp_info: >> kfree(bp_info); >>

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On Wed, 17 Aug 2016 20:10:37 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 Aug 2016 19:25:50 +0200 > > The kfree() function was called in a few cases by the > kvm_s390_import_bp_data() function during error

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

On Wed, 17 Aug 2016 20:10:37 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 Aug 2016 19:25:50 +0200 > > The kfree() function was called in a few cases by the > kvm_s390_import_bp_data() function during error handling > even if a passed variable contained a null pointer.

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

> From: Markus Elfring > Date: Wed, 17 Aug 2016 19:25:50 +0200 > > The kfree() function was called in a few cases by the > kvm_s390_import_bp_data() function during error handling > even if a passed variable contained a null pointer. > > Adjust jump targets

Re: [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

> From: Markus Elfring > Date: Wed, 17 Aug 2016 19:25:50 +0200 > > The kfree() function was called in a few cases by the > kvm_s390_import_bp_data() function during error handling > even if a passed variable contained a null pointer. > > Adjust jump targets according to the Linux coding style

[PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

From: Markus Elfring Date: Wed, 17 Aug 2016 19:25:50 +0200 The kfree() function was called in a few cases by the kvm_s390_import_bp_data() function during error handling even if a passed variable contained a null pointer. Adjust jump targets according to the Linux

[PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection

From: Markus Elfring Date: Wed, 17 Aug 2016 19:25:50 +0200 The kfree() function was called in a few cases by the kvm_s390_import_bp_data() function during error handling even if a passed variable contained a null pointer. Adjust jump targets according to the Linux coding style convention.