Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-11 Thread Nick Desaulniers
On Mon, Feb 11, 2019 at 8:05 AM Sedat Dilek wrote: > > On Mon, Feb 11, 2019 at 4:33 PM Masahiro Yamada > wrote: > [ ... ] > > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/342 > > > > > Suggested-by: Nathan Chancellor > > > > > Signed-off-by: Nick Desaulniers > > > > > --- > > >

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-11 Thread Nick Desaulniers
On Thu, Feb 7, 2019 at 9:51 PM Nathan Chancellor wrote: > > On Thu, Feb 07, 2019 at 02:01:51PM -0800, ndesaulni...@google.com wrote: > > This is needed because clang doesn't select which linker to use based on > > $LD but rather -fuse-ld=$(LD). This is problematic especially for > > cc-ldoption,

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-11 Thread Nick Desaulniers
On Mon, Feb 11, 2019 at 7:33 AM Masahiro Yamada wrote: > > On Sat, Feb 9, 2019 at 2:27 AM Nick Desaulniers > wrote: > > > > On Thu, Feb 7, 2019 at 9:51 PM Nathan Chancellor > > wrote: > > > > > > On Thu, Feb 07, 2019 at 02:01:51PM -0800, ndesaulni...@google.com wrote: > > > > This is needed

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-11 Thread Sedat Dilek
On Mon, Feb 11, 2019 at 4:33 PM Masahiro Yamada wrote: [ ... ] > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/342 > > > > Suggested-by: Nathan Chancellor > > > > Signed-off-by: Nick Desaulniers > > > > --- > > > > Makefile | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > >

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-11 Thread Masahiro Yamada
On Sat, Feb 9, 2019 at 2:27 AM Nick Desaulniers wrote: > > On Thu, Feb 7, 2019 at 9:51 PM Nathan Chancellor > wrote: > > > > On Thu, Feb 07, 2019 at 02:01:51PM -0800, ndesaulni...@google.com wrote: > > > This is needed because clang doesn't select which linker to use based on > > > $LD but

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-08 Thread Nathan Chancellor
On Fri, Feb 08, 2019 at 09:27:19AM -0800, Nick Desaulniers wrote: > On Thu, Feb 7, 2019 at 9:51 PM Nathan Chancellor > wrote: > > > > On Thu, Feb 07, 2019 at 02:01:51PM -0800, ndesaulni...@google.com wrote: > > > This is needed because clang doesn't select which linker to use based on > > > $LD

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-08 Thread Nick Desaulniers
On Thu, Feb 7, 2019 at 9:51 PM Nathan Chancellor wrote: > > On Thu, Feb 07, 2019 at 02:01:51PM -0800, ndesaulni...@google.com wrote: > > This is needed because clang doesn't select which linker to use based on > > $LD but rather -fuse-ld=$(LD). This is problematic especially for > > cc-ldoption,

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-08 Thread Nathan Chancellor
On Fri, Feb 08, 2019 at 03:21:15PM +0100, Sedat Dilek wrote: > Hi Nick, > > why don't you simply check for CONFIG_LD_IS_LLD existing (when [1] applied)? > Hi Sedat, This section runs before Kconfig so we can't rely on the symbols it generates. See commit 995167420797 ("kbuild: remove cc-name

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-08 Thread Sedat Dilek
Hi Nick, why don't you simply check for CONFIG_LD_IS_LLD existing (when [1] applied)? If you want a specific version of ld.lld (you mentioned kernel module linking failure was fixed recently) why not transfer this into a scripts/lld-version.sh file? Greetings, - Sedat - [1]

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-07 Thread Nathan Chancellor
On Thu, Feb 07, 2019 at 02:01:51PM -0800, ndesaulni...@google.com wrote: > This is needed because clang doesn't select which linker to use based on > $LD but rather -fuse-ld=$(LD). This is problematic especially for > cc-ldoption, which checks for linker flag support via invoking the > compiler,

[PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-07 Thread ndesaulniers
This is needed because clang doesn't select which linker to use based on $LD but rather -fuse-ld=$(LD). This is problematic especially for cc-ldoption, which checks for linker flag support via invoking the compiler, rather than the linker. Link: https://github.com/ClangBuiltLinux/linux/issues/342