Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-30 Thread Atish Patra
On Tue, 2019-07-30 at 17:08 -0700, Paul Walmsley wrote: > On Mon, 29 Jul 2019, Atish Patra wrote: > > > The yaml document did not specify anything about all isa-strings > > has to > > be lowercase unless I missed something. The two enum values are > > all > > lowercase but the description says a

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-30 Thread Paul Walmsley
On Mon, 29 Jul 2019, Atish Patra wrote: > The yaml document did not specify anything about all isa-strings has to > be lowercase unless I missed something. The two enum values are all > lowercase but the description says all ISA strings are documented in ISA > specification which describes the

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-30 Thread Paul Walmsley
On Sat, 27 Jul 2019, Anup Patel wrote: > On Sat, Jul 27, 2019 at 1:46 PM Paul Walmsley > wrote: > > > > On Sat, 27 Jul 2019, Anup Patel wrote: > > > > > If your only objection is uppercase letter not agreeing with YMAL > > > schema then why not fix the YMAL schema to have regex for RISC-V ISA

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-30 Thread Atish Patra
On Mon, 2019-07-29 at 20:42 -0700, Palmer Dabbelt wrote: > On Fri, 26 Jul 2019 15:20:47 PDT (-0700), Atish Patra wrote: > > On 7/26/19 1:47 PM, Paul Walmsley wrote: > > > On Fri, 26 Jul 2019, Atish Patra wrote: > > > > > > > As per riscv specification, ISA naming strings are > > > > case insensiti

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-29 Thread Palmer Dabbelt
On Fri, 26 Jul 2019 15:20:47 PDT (-0700), Atish Patra wrote: On 7/26/19 1:47 PM, Paul Walmsley wrote: On Fri, 26 Jul 2019, Atish Patra wrote: As per riscv specification, ISA naming strings are case insensitive. However, currently only lower case strings are parsed during cpu procfs. Support p

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-29 Thread Atish Patra
On Sat, 2019-07-27 at 01:16 -0700, Paul Walmsley wrote: > On Sat, 27 Jul 2019, Anup Patel wrote: > > > If your only objection is uppercase letter not agreeing with YMAL > > schema > > then why not fix the YMAL schema to have regex for RISC-V ISA > > string? > > I don't agree with you that the spe

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-29 Thread Andreas Schwab
On Jul 27 2019, Anup Patel wrote: > So, using strncasecmp() in-place of strncmp() and using tolower() for > each character comparison is complex for you ? Apparently too complex for you. + if (tolower(isa[0] != 's')) Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-27 Thread Anup Patel
On Sat, Jul 27, 2019 at 1:46 PM Paul Walmsley wrote: > > On Sat, 27 Jul 2019, Anup Patel wrote: > > > If your only objection is uppercase letter not agreeing with YMAL schema > > then why not fix the YMAL schema to have regex for RISC-V ISA string? > > I don't agree with you that the specification

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-27 Thread Paul Walmsley
On Sat, 27 Jul 2019, Anup Patel wrote: > If your only objection is uppercase letter not agreeing with YMAL schema > then why not fix the YMAL schema to have regex for RISC-V ISA string? I don't agree with you that the specification compels software to accept arbitrary case combinations in the ri

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-27 Thread Anup Patel
On Sat, Jul 27, 2019 at 1:23 PM Paul Walmsley wrote: > > On Sat, 27 Jul 2019, Anup Patel wrote: > > > > -Original Message- > > > From: Paul Walmsley > > > Sent: Saturday, July 27, 2019 5:00 AM > > > > > > On Fri, 26 Jul 2019, Atish Patra wrote: > > > > > > > On 7/26/19 1:47 PM, Paul Walms

RE: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-27 Thread Paul Walmsley
On Sat, 27 Jul 2019, Anup Patel wrote: > > -Original Message- > > From: Paul Walmsley > > Sent: Saturday, July 27, 2019 5:00 AM > > > > On Fri, 26 Jul 2019, Atish Patra wrote: > > > > > On 7/26/19 1:47 PM, Paul Walmsley wrote: > > > > On Fri, 26 Jul 2019, Atish Patra wrote: > > > > > >

RE: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-26 Thread Anup Patel
> ri...@lists.infradead.org; Palmer Dabbelt ; Thomas > Gleixner > Subject: Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing. > > On Fri, 26 Jul 2019, Atish Patra wrote: > > > On 7/26/19 1:47 PM, Paul Walmsley wrote: > > > On Fri, 26 Jul 2019,

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-26 Thread Paul Walmsley
On Fri, 26 Jul 2019, Atish Patra wrote: > On 7/26/19 1:47 PM, Paul Walmsley wrote: > > On Fri, 26 Jul 2019, Atish Patra wrote: > > > > > As per riscv specification, ISA naming strings are > > > case insensitive. However, currently only lower case > > > strings are parsed during cpu procfs. > > >

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-26 Thread Atish Patra
On 7/26/19 1:47 PM, Paul Walmsley wrote: On Fri, 26 Jul 2019, Atish Patra wrote: As per riscv specification, ISA naming strings are case insensitive. However, currently only lower case strings are parsed during cpu procfs. Support parsing of upper case letters as well. Signed-off-by: Atish Pa

Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-26 Thread Paul Walmsley
On Fri, 26 Jul 2019, Atish Patra wrote: > As per riscv specification, ISA naming strings are > case insensitive. However, currently only lower case > strings are parsed during cpu procfs. > > Support parsing of upper case letters as well. > > Signed-off-by: Atish Patra Is there a use case that

[PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.

2019-07-26 Thread Atish Patra
As per riscv specification, ISA naming strings are case insensitive. However, currently only lower case strings are parsed during cpu procfs. Support parsing of upper case letters as well. Signed-off-by: Atish Patra --- arch/riscv/kernel/cpu.c | 9 + 1 file changed, 5 insertions(+), 4 d