Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Krzysztof Kozlowski
On Wed, Jan 04, 2017 at 12:29:23AM +0900, Chanwoo Choi wrote: > Hi Andi, > > 2017-01-03 23:40 GMT+09:00 Andi Shyti : > > Hi, > > > >> FWIW, I also agree with Chanwoo that the difference is too small to > >> need a common .dtsi file. > > > > in principle I don't like "switching on and off" properti

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Krzysztof Kozlowski
On Tue, Jan 03, 2017 at 07:25:48PM +0900, Andi Shyti wrote: > > >> > Currently tm2e dts includes tm2 but there are some differences > > >> > between the two boards and tm2 has some properties that tm2e > > >> > doesn't have. > > >> > > > >> > That's why it's important to keep the two dts files inde

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Chanwoo Choi
Hi Andi, 2017-01-03 23:40 GMT+09:00 Andi Shyti : > Hi, > >> FWIW, I also agree with Chanwoo that the difference is too small to >> need a common .dtsi file. > > in principle I don't like "switching on and off" properties by > overwriting them with "status = disable", unless it's really > necessary

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Javier Martinez Canillas
Hello Andi, On 01/03/2017 11:40 AM, Andi Shyti wrote: > Hi, > >> FWIW, I also agree with Chanwoo that the difference is too small to >> need a common .dtsi file. > > in principle I don't like "switching on and off" properties by > overwriting them with "status = disable", unless it's really Thi

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Andi Shyti
Hi, > FWIW, I also agree with Chanwoo that the difference is too small to > need a common .dtsi file. in principle I don't like "switching on and off" properties by overwriting them with "status = disable", unless it's really necessary (and this case is not). Even for small differences. It makes

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Javier Martinez Canillas
Hello Andi, On 01/03/2017 08:55 AM, Andi Shyti wrote: > Hi Chanwoo, > >>> Currently tm2e dts includes tm2 but there are some differences >>> between the two boards and tm2 has some properties that tm2e >>> doesn't have. >>> >>> That's why it's important to keep the two dts fil

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Andi Shyti
Hi Chanwoo, > >> >> > Currently tm2e dts includes tm2 but there are some differences > >> >> > between the two boards and tm2 has some properties that tm2e > >> >> > doesn't have. > >> >> > > >> >> > That's why it's important to keep the two dts files independent > >> >> > and put all the commonal

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Chanwoo Choi
Dear all, 2017-01-03 19:25 GMT+09:00 Andi Shyti : >> >> > Currently tm2e dts includes tm2 but there are some differences >> >> > between the two boards and tm2 has some properties that tm2e >> >> > doesn't have. >> >> > >> >> > That's why it's important to keep the two dts files independent >> >>

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Andi Shyti
> >> > Currently tm2e dts includes tm2 but there are some differences > >> > between the two boards and tm2 has some properties that tm2e > >> > doesn't have. > >> > > >> > That's why it's important to keep the two dts files independent > >> > and put all the commonalities in a tm2-common.dtsi file

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Krzysztof Kozlowski
On Tue, Jan 3, 2017 at 11:58 AM, Andi Shyti wrote: > Hi Krzysztof, > >> > Currently tm2e dts includes tm2 but there are some differences >> > between the two boards and tm2 has some properties that tm2e >> > doesn't have. >> > >> > That's why it's important to keep the two dts files independent >>

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Andi Shyti
Hi Krzysztof, > > Currently tm2e dts includes tm2 but there are some differences > > between the two boards and tm2 has some properties that tm2e > > doesn't have. > > > > That's why it's important to keep the two dts files independent > > and put all the commonalities in a tm2-common.dtsi file. >

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Krzysztof Kozlowski
On Tue, Jan 3, 2017 at 9:57 AM, Jaechul Lee wrote: > From: Andi Shyti > > Currently tm2e dts includes tm2 but there are some differences > between the two boards and tm2 has some properties that tm2e > doesn't have. > > That's why it's important to keep the two dts files independent > and put all

Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-03 Thread Andi Shyti
Hi, > + compatible = "samsung,tm2e", "samsung,exynos5433"; this is supposed to be "samsung,tm2". Will wait for other comments and fix it in v2. Andi

[PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-02 Thread Jaechul Lee
From: Andi Shyti Currently tm2e dts includes tm2 but there are some differences between the two boards and tm2 has some properties that tm2e doesn't have. That's why it's important to keep the two dts files independent and put all the commonalities in a tm2-common.dtsi file. Signed-off-by: Andi