Re: [PATCH 3/4] atm: idt77252: Remove redundant error check

2014-05-18 Thread David Miller
From: Peter Senna Tschudin Date: Sat, 17 May 2014 20:22:59 +0200 > Remove double checks, and move the call to printk to the > first check. Also adds KERN_WARNING to printk. The simplified version > of the coccinelle semantic patch that fixes this issue is as follows: The appropriate thing to

Re: [PATCH 3/4] atm: idt77252: Remove redundant error check

2014-05-18 Thread David Miller
From: Peter Senna Tschudin peter.se...@gmail.com Date: Sat, 17 May 2014 20:22:59 +0200 Remove double checks, and move the call to printk to the first check. Also adds KERN_WARNING to printk. The simplified version of the coccinelle semantic patch that fixes this issue is as follows: The

[PATCH 3/4] atm: idt77252: Remove redundant error check

2014-05-17 Thread Peter Senna Tschudin
Remove double checks, and move the call to printk to the first check. Also adds KERN_WARNING to printk. The simplified version of the coccinelle semantic patch that fixes this issue is as follows: // @@ expression E; identifier pr; expression list es; @@ while(...){ ... - if (E) break; +

[PATCH 3/4] atm: idt77252: Remove redundant error check

2014-05-17 Thread Peter Senna Tschudin
Remove double checks, and move the call to printk to the first check. Also adds KERN_WARNING to printk. The simplified version of the coccinelle semantic patch that fixes this issue is as follows: // smpl @@ expression E; identifier pr; expression list es; @@ while(...){ ... - if (E) break;