Re: [PATCH 3/4] bitmap_parselist: rework input string parser

2019-01-09 Thread Yuri Norov
On Wed, Jan 09, 2019 at 06:01:46PM +0200, Andy Shevchenko wrote: > On Sun, Dec 23, 2018 at 09:44:55AM +, Yuri Norov wrote: > > The requirement for this rework is to keep the __bitmap_parselist() > > copy-less and single-pass but make it more readable and maintainable by > > splitting into

Re: [PATCH 3/4] bitmap_parselist: rework input string parser

2019-01-09 Thread Andy Shevchenko
On Sun, Dec 23, 2018 at 09:44:55AM +, Yuri Norov wrote: > The requirement for this rework is to keep the __bitmap_parselist() > copy-less and single-pass but make it more readable and maintainable by > splitting into logical parts and removing explicit nested cycles and > opaque local

Re: [PATCH 3/4] bitmap_parselist: rework input string parser

2018-12-23 Thread kbuild test robot
Hi Yuri, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc7 next-20181221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 3/4] bitmap_parselist: rework input string parser

2018-12-23 Thread Yuri Norov
The requirement for this rework is to keep the __bitmap_parselist() copy-less and single-pass but make it more readable and maintainable by splitting into logical parts and removing explicit nested cycles and opaque local variables. __bitmap_parselist() can parse userspace inputs and therefore we