Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-20 Thread Matthew Garrett
On Wed, 2013-03-20 at 10:41 -0400, Vivek Goyal wrote: > I am not sure why CAP_COMPROMISE_KERNEL(CAP_MODIFY_KERNEL) is any > different. When secureboot is enabled, kernel will take away that > capability from all the processes. So kernel became a decision maker > too whether processes have

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-20 Thread Vivek Goyal
On Wed, Mar 20, 2013 at 04:07:58PM +1100, James Morris wrote: > On Fri, 15 Mar 2013, Casey Schaufler wrote: > > > Capabilities aren't just random attribute bits. They > > indicate that a task has permission to violate a > > system policy (e.g. change the mode bits of a file > > the user doesn't

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-20 Thread Vivek Goyal
On Wed, Mar 20, 2013 at 04:07:58PM +1100, James Morris wrote: On Fri, 15 Mar 2013, Casey Schaufler wrote: Capabilities aren't just random attribute bits. They indicate that a task has permission to violate a system policy (e.g. change the mode bits of a file the user doesn't own).

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-20 Thread Matthew Garrett
On Wed, 2013-03-20 at 10:41 -0400, Vivek Goyal wrote: I am not sure why CAP_COMPROMISE_KERNEL(CAP_MODIFY_KERNEL) is any different. When secureboot is enabled, kernel will take away that capability from all the processes. So kernel became a decision maker too whether processes have

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-19 Thread James Morris
On Fri, 15 Mar 2013, Casey Schaufler wrote: > Capabilities aren't just random attribute bits. They > indicate that a task has permission to violate a > system policy (e.g. change the mode bits of a file > the user doesn't own). Casey's right here, as well he should be. -- James Morris -- To

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-19 Thread Serge E. Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > > Adding Serge as he is the sometimes capabilities maintainer to this > discussion. Thanks, Eric. > Casey Schaufler writes: > > > On 3/18/2013 11:30 AM, Vivek Goyal wrote: > >> On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey Schaufler

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-19 Thread Serge E. Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): Adding Serge as he is the sometimes capabilities maintainer to this discussion. Thanks, Eric. Casey Schaufler ca...@schaufler-ca.com writes: On 3/18/2013 11:30 AM, Vivek Goyal wrote: On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-19 Thread James Morris
On Fri, 15 Mar 2013, Casey Schaufler wrote: Capabilities aren't just random attribute bits. They indicate that a task has permission to violate a system policy (e.g. change the mode bits of a file the user doesn't own). Casey's right here, as well he should be. -- James Morris

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Eric W. Biederman
Adding Serge as he is the sometimes capabilities maintainer to this discussion. Casey Schaufler writes: > On 3/18/2013 11:30 AM, Vivek Goyal wrote: >> On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey Schaufler wrote: >>> On 3/18/2013 10:05 AM, Vivek Goyal wrote: On Fri, Mar 15, 2013 at

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Casey Schaufler
On 3/18/2013 11:30 AM, Vivek Goyal wrote: > On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey Schaufler wrote: >> On 3/18/2013 10:05 AM, Vivek Goyal wrote: >>> On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: On 3/15/2013 1:35 PM, Vivek Goyal wrote: > Create a new capability

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Vivek Goyal
On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey Schaufler wrote: > On 3/18/2013 10:05 AM, Vivek Goyal wrote: > > On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: > >> On 3/15/2013 1:35 PM, Vivek Goyal wrote: > >>> Create a new capability CAP_SIGNED which can be given to signed >

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Casey Schaufler
On 3/18/2013 10:05 AM, Vivek Goyal wrote: > On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: >> On 3/15/2013 1:35 PM, Vivek Goyal wrote: >>> Create a new capability CAP_SIGNED which can be given to signed executables. >> This would drive anyone who is trying to use >> capabilities

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Vivek Goyal
On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: > On 3/15/2013 1:35 PM, Vivek Goyal wrote: > > Create a new capability CAP_SIGNED which can be given to signed executables. > > This would drive anyone who is trying to use > capabilities as the privilege mechanism it is > intended

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Vivek Goyal
On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: On 3/15/2013 1:35 PM, Vivek Goyal wrote: Create a new capability CAP_SIGNED which can be given to signed executables. This would drive anyone who is trying to use capabilities as the privilege mechanism it is intended to be

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Casey Schaufler
On 3/18/2013 10:05 AM, Vivek Goyal wrote: On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: On 3/15/2013 1:35 PM, Vivek Goyal wrote: Create a new capability CAP_SIGNED which can be given to signed executables. This would drive anyone who is trying to use capabilities as the

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Vivek Goyal
On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey Schaufler wrote: On 3/18/2013 10:05 AM, Vivek Goyal wrote: On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: On 3/15/2013 1:35 PM, Vivek Goyal wrote: Create a new capability CAP_SIGNED which can be given to signed

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Casey Schaufler
On 3/18/2013 11:30 AM, Vivek Goyal wrote: On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey Schaufler wrote: On 3/18/2013 10:05 AM, Vivek Goyal wrote: On Fri, Mar 15, 2013 at 02:12:59PM -0700, Casey Schaufler wrote: On 3/15/2013 1:35 PM, Vivek Goyal wrote: Create a new capability CAP_SIGNED

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-18 Thread Eric W. Biederman
Adding Serge as he is the sometimes capabilities maintainer to this discussion. Casey Schaufler ca...@schaufler-ca.com writes: On 3/18/2013 11:30 AM, Vivek Goyal wrote: On Mon, Mar 18, 2013 at 10:50:21AM -0700, Casey Schaufler wrote: On 3/18/2013 10:05 AM, Vivek Goyal wrote: On Fri, Mar 15,

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-15 Thread Casey Schaufler
On 3/15/2013 1:35 PM, Vivek Goyal wrote: > Create a new capability CAP_SIGNED which can be given to signed executables. This would drive anyone who is trying to use capabilities as the privilege mechanism it is intended to be absolutely crazy. Capabilities aren't just random attribute bits. They

[PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-15 Thread Vivek Goyal
Create a new capability CAP_SIGNED which can be given to signed executables. Signed-off-by: Vivek Goyal --- include/uapi/linux/capability.h | 12 +++- kernel/cred.c |7 +++ security/commoncap.c|2 ++ 3 files changed, 20 insertions(+), 1

[PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-15 Thread Vivek Goyal
Create a new capability CAP_SIGNED which can be given to signed executables. Signed-off-by: Vivek Goyal vgo...@redhat.com --- include/uapi/linux/capability.h | 12 +++- kernel/cred.c |7 +++ security/commoncap.c|2 ++ 3 files changed, 20

Re: [PATCH 3/4] capability: Create a new capability CAP_SIGNED

2013-03-15 Thread Casey Schaufler
On 3/15/2013 1:35 PM, Vivek Goyal wrote: Create a new capability CAP_SIGNED which can be given to signed executables. This would drive anyone who is trying to use capabilities as the privilege mechanism it is intended to be absolutely crazy. Capabilities aren't just random attribute bits. They