Re: [PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-14 Thread Heiko Stuebner
Am Montag, 14. Januar 2019, 11:05:56 CET schrieb Daniel Vetter: > On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote: > > Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > > > The device node iterators perform an of_node_get on each iteration, so a > > > jump out of the

Re: [PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-14 Thread Daniel Vetter
On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote: > Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > > The device node iterators perform an of_node_get on each iteration, so a > > jump out of the loop requires an of_node_put. > > > > The semantic patch that fixes thi

Re: [PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-13 Thread Heiko Stuebner
Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > exp

[PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-13 Thread Julia Lawall
The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator name for_each_child_of_node; @@