Re: [PATCH 3/4] firewire: enforce access order between generation and node ID

2008-01-25 Thread Stefan Richter
Kristian Høgsberg wrote: > I'm down with the flu here, but I read through the threads and the > patches and this work definitely looks good. Thanks for keeping your eyes on us. Your sign-off will go in when I build the for-linus branch. Get well, -- Stefan Richter -=-==--- ---= ==--= http:/

Re: [PATCH 3/4] firewire: enforce access order between generation and node ID

2008-01-25 Thread Stefan Richter
Stefan Richter wrote: > I'm going to commit it with a whitespace adjustment and a comment typo > fixed. Also forgot to #include in some of the files. Here is the final product, for the record. From: Stefan Richter <[EMAIL PROTECTED]> Subject: firewire: enforce access order between generation a

Re: [PATCH 3/4] firewire: enforce access order between generation and node ID

2008-01-25 Thread Stefan Richter
I'm going to commit it with a whitespace adjustment and a comment typo fixed. Jarod, thanks for the rigorous testing; Nick, thanks for helping in making this a solid improvement over the initial submission. -- Stefan Richter -=-==--- ---= ==--= http://arcgraph.de/sr/ -- To unsubscribe from t

Re: [PATCH 3/4] firewire: enforce access order between generation and node ID

2008-01-24 Thread Jarod Wilson
Stefan Richter wrote: > fw_device.node_id and fw_device.generation are accessed without mutexes. > We have to ensure that all readers will get to see node_id updates > before generation updates. > > An earlier incarnation of this patch fixes an inability to recognize > devices after "giving up on

Re: [PATCH 3/4] firewire: enforce access order between generation and node ID

2008-01-23 Thread Nick Piggin
On Thursday 24 January 2008 11:54, Stefan Richter wrote: > fw_device.node_id and fw_device.generation are accessed without mutexes. > We have to ensure that all readers will get to see node_id updates > before generation updates. > > An earlier incarnation of this patch fixes an inability to recogn

[PATCH 3/4] firewire: enforce access order between generation and node ID

2008-01-23 Thread Stefan Richter
fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before generation updates. An earlier incarnation of this patch fixes an inability to recognize devices after "giving up on config rom", https://bugzilla.redh