Re: [PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing

2020-07-09 Thread Cristian Marussi
On Wed, Jul 08, 2020 at 10:38:08PM +0200, Arnd Bergmann wrote: > On Wed, Jul 8, 2020 at 2:24 PM Cristian Marussi > wrote: > > > > Drop size_t in favour of fixed size u32 for consistency and shuffle > > around fields definitions to minimize implicit padding. > > > > Signed-off-by: Cristian Marussi

Re: [PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing

2020-07-08 Thread Arnd Bergmann
On Wed, Jul 8, 2020 at 2:24 PM Cristian Marussi wrote: > > Drop size_t in favour of fixed size u32 for consistency and shuffle > around fields definitions to minimize implicit padding. > > Signed-off-by: Cristian Marussi As you still have implicit padding at the end, I'd either make that explici

[PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing

2020-07-08 Thread Cristian Marussi
Drop size_t in favour of fixed size u32 for consistency and shuffle around fields definitions to minimize implicit padding. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/notify.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi