Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-17 Thread Serge E. Hallyn
Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): > > Mimi Zohar writes: > > On Wed, 2018-03-14 at 21:03 -0300, Thiago Jung Bauermann wrote: > >> Hello Serge, > >> > >> Thanks for quickly reviewing these patches! > >> > >> Serge E. Hallyn

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-17 Thread Serge E. Hallyn
Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): > > Mimi Zohar writes: > > On Wed, 2018-03-14 at 21:03 -0300, Thiago Jung Bauermann wrote: > >> Hello Serge, > >> > >> Thanks for quickly reviewing these patches! > >> > >> Serge E. Hallyn writes: > >> > >> > Quoting Thiago Jung

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-15 Thread Thiago Jung Bauermann
Mimi Zohar writes: > On Wed, 2018-03-14 at 21:03 -0300, Thiago Jung Bauermann wrote: >> Hello Serge, >> >> Thanks for quickly reviewing these patches! >> >> Serge E. Hallyn writes: >> >> > Quoting Thiago Jung Bauermann

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-15 Thread Thiago Jung Bauermann
Mimi Zohar writes: > On Wed, 2018-03-14 at 21:03 -0300, Thiago Jung Bauermann wrote: >> Hello Serge, >> >> Thanks for quickly reviewing these patches! >> >> Serge E. Hallyn writes: >> >> > Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): >> >> From: Mimi Zohar >> >> @@ -241,16

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-15 Thread Mimi Zohar
On Wed, 2018-03-14 at 21:03 -0300, Thiago Jung Bauermann wrote: > Hello Serge, > > Thanks for quickly reviewing these patches! > > Serge E. Hallyn writes: > > > Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): > >> From: Mimi Zohar > >>

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-15 Thread Mimi Zohar
On Wed, 2018-03-14 at 21:03 -0300, Thiago Jung Bauermann wrote: > Hello Serge, > > Thanks for quickly reviewing these patches! > > Serge E. Hallyn writes: > > > Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): > >> From: Mimi Zohar > >> @@ -241,16 +241,20 @@ int

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-14 Thread Thiago Jung Bauermann
Hello Serge, Thanks for quickly reviewing these patches! Serge E. Hallyn writes: > Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): >> From: Mimi Zohar >> @@ -241,16 +241,20 @@ int ima_appraise_measurement(enum ima_hooks func, >> }

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-14 Thread Thiago Jung Bauermann
Hello Serge, Thanks for quickly reviewing these patches! Serge E. Hallyn writes: > Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): >> From: Mimi Zohar >> @@ -241,16 +241,20 @@ int ima_appraise_measurement(enum ima_hooks func, >> } >> >> status =

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-14 Thread Serge E. Hallyn
Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): > From: Mimi Zohar > > Replace nested ifs in the EVM xattr verification logic with a switch > statement, making the code easier to understand. > > Also, add comments to the if statements in the out section

Re: [PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-14 Thread Serge E. Hallyn
Quoting Thiago Jung Bauermann (bauer...@linux.vnet.ibm.com): > From: Mimi Zohar > > Replace nested ifs in the EVM xattr verification logic with a switch > statement, making the code easier to understand. > > Also, add comments to the if statements in the out section and constify the > cause

[PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-14 Thread Thiago Jung Bauermann
From: Mimi Zohar Replace nested ifs in the EVM xattr verification logic with a switch statement, making the code easier to understand. Also, add comments to the if statements in the out section and constify the cause variable. Signed-off-by: Mimi Zohar

[PATCH 3/4] ima: Improvements in ima_appraise_measurement()

2018-03-14 Thread Thiago Jung Bauermann
From: Mimi Zohar Replace nested ifs in the EVM xattr verification logic with a switch statement, making the code easier to understand. Also, add comments to the if statements in the out section and constify the cause variable. Signed-off-by: Mimi Zohar Signed-off-by: Thiago Jung Bauermann