Re: [PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Joe Perches
On Thu, 2013-05-16 at 22:47 -0500, Corey Minyard wrote: > On 05/16/2013 05:23 PM, Andy Lutomirski wrote: > > > > /* We got the flags from the SMI, now handle them. */ > > smi_info->handlers->get_result(smi_info->si_sm, msg, 4); > > - if (msg[2] != 0)

Re: [PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Corey Minyard
On 05/16/2013 05:23 PM, Andy Lutomirski wrote: /* We got the flags from the SMI, now handle them. */ smi_info->handlers->get_result(smi_info->si_sm, msg, 4); - if (msg[2] != 0) - dev_warn(smi_info->dev, "Could not enable inter

Re: [PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Andy Lutomirski
On Thu, May 16, 2013 at 12:04 PM, Corey Minyard wrote: > When the interrupt enable message returns an error, the messages are > not entirely accurate nor helpful. So improve them. > > Signed-off-by: Corey Minyard > Cc: Andy Lutomirski > --- > drivers/char/ipmi/ipmi_si_intf.c | 16 ++-

[PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Corey Minyard
When the interrupt enable message returns an error, the messages are not entirely accurate nor helpful. So improve them. Signed-off-by: Corey Minyard Cc: Andy Lutomirski --- drivers/char/ipmi/ipmi_si_intf.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a